ServiceAreaServiceImpl deadlocks when calculating default search area

[sheldonabrown]

The call to the _transitDataService takes place before the TDS has been initialized, and causes a deadlock on startup.

@PostConstruct
  public void setup() {

    if (_calculateDefaultBoundsFromAgencyCoverage) {
      List<AgencyWithCoverageBean> agenciesWithCoverage = _transitDataService.getAgenciesWithCoverage();
      CoordinateBounds bounds = new CoordinateBounds();
....
}

[sheldonabrown]

The quick fix is to turn off the default bounds calculation in data-sources.xml

  <bean id="serviceAreaServiceImpl" class="org.onebusaway.presentation.impl.ServiceAreaServiceImpl">
    <property name="defaultBounds">
      <bean class="org.onebusaway.geospatial.model.CoordinateBounds">
        <property name="minLat" value="xx.xxx" />
        <property name="minLon" value="yy.yyy" />
        <property name="maxLat" value="xx.xxx" />
        <property name="maxLon" value="yy.yyy" />
      </bean>
    </property>
    <property name="calculateDefaultBoundsFromAgencyCoverage" value="false" />
  </bean>

The longer term fix may be moving this to a background thread.