Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bogus timezones do not cause exceptions #6

Closed
novalis opened this issue Apr 19, 2012 · 2 comments
Closed

Bogus timezones do not cause exceptions #6

novalis opened this issue Apr 19, 2012 · 2 comments

Comments

@novalis
Copy link
Member

novalis commented Apr 19, 2012

https://github.com/OneBusAway/onebusaway-gtfs-modules/blob/master/onebusaway-gtfs/src/main/java/org/onebusaway/gtfs/impl/calendar/CalendarServiceDataFactoryImpl.java#L149

The code expects getTimeZone to return null in the event that a timezone cannot be found. It in fact returns GMT. This is, IMHO, a bug in Java. But good luck getting Oracle to do anything about it.

I propose replacing the null check with a check for GMT. No real feeds should use GMT; instead they should use Europe/London or whatever.

@bdferris
Copy link
Member

Things I did not know about Java.

@novalis
Copy link
Member Author

novalis commented Apr 19, 2012

Me neither!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants