Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OK-28046 OK-28150 feat: remove hardware sdk url setting #4686

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

kwoktung
Copy link
Contributor

@kwoktung kwoktung commented Jun 4, 2024

No description provided.

Copy link

codesandbox bot commented Jun 4, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

what-the-diff bot commented Jun 4, 2024

PR Summary

  • Removal of setHardwareConnectSrc function
    The function was deleted from ServiceSetting.ts.
  • Addition of Empty component
    Introduced on Currency's ListEmptyComponent prop.
  • Deletion of HardwareSdkUrl
    This file was entirely removed.
  • ListItem change to AdvancedSection
    hardwareConnectSrc ListItem was removed.
  • Changes in router
    Removed import and route for SettingHardwareSdkUrlModal.
  • Modification of generateConnectSrc function
    Now always uses HARDWARE_SDK_IFRAME_SRC_ONEKEYSO as connectSrc.
  • Removed SettingHardwareSdkUrlModal route
    This route was taken out from routes/setting.ts.
  • Removed ONEKEY_CN enum value
    This value was removed from EOnekeyDomain enum.

@kwoktung kwoktung enabled auto-merge (squash) June 4, 2024 13:22
@kwoktung kwoktung merged commit 3f7131b into x Jun 5, 2024
4 checks passed
@kwoktung kwoktung deleted the remove_hardware_sdk_setting branch June 5, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants