Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should static/OZTreeModule/dist/OZui.html have a <head> tag? #802

Closed
hyanwong opened this issue Apr 16, 2024 · 3 comments
Closed

Should static/OZTreeModule/dist/OZui.html have a <head> tag? #802

hyanwong opened this issue Apr 16, 2024 · 3 comments

Comments

@hyanwong
Copy link
Member

hyanwong commented Apr 16, 2024 •
edited
Loading

We are calling

<head>
...
 {{include '../static/OZTreeModule/dist/OZui.html'}}
...
</head>

in a few layout files, but that OZui,html file (which is only to allow easy inclusion of a file with a changed name) itself includes.a <head> tag. That sounds bad to me. I wonder if it explains all those "Can't find variable OZui" errors (e.g. #801 (comment))
@hyanwong
Copy link
Member Author

Also, is the {{include ...}} with a hard-coded file path the right way to do this? It would seem better to me to add it to response.files, so that we don't end up importing it multiple times. But I don't know if you can include an HTML file like that: it might just be css / js files?

This was referenced Apr 16, 2024
Closed
Closed
@hyanwong
Copy link
Member Author

Seems like we might want inject: false, and a custom template. See e.g. https://www.npmjs.com/package/html-webpack-plugin#writing-your-own-templates

Screenshot 2024-04-16 at 19 33 28

@hyanwong
Copy link
Member Author

Fixed by #803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyanwong