-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input arg modifier return maybe #5453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neflow-inc/oneflow into OutputArgModifier_return_maybe_part_1
…b.com/oneflow-inc/oneflow into Replace_check_using_maybe_check_part_SetInputArgModifyFn
…neflow-inc/oneflow into OutputArgModifier_return_maybe_part_1 Conflicts: oneflow/core/operator/operator.cpp
…b.com/oneflow-inc/oneflow into input_arg_modifier_return_maybe
Merged
liufengwei0103
force-pushed
the
OutputArgModifier_return_maybe_part_1
branch
2 times, most recently
from
July 12, 2021 03:23
8663cac
to
9f140e1
Compare
…input_arg_modifier_return_maybe Conflicts: oneflow/core/job/job_build_and_infer_ctx.cpp oneflow/core/job/job_builder.cpp oneflow/core/job/job_builder.h oneflow/core/job_rewriter/autograd.cpp oneflow/core/job_rewriter/autotick.cpp oneflow/core/operator/user_op.cpp
lixinqi
approved these changes
Jul 15, 2021
lixinqi
approved these changes
Jul 15, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
July 15, 2021 11:40
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
July 15, 2021 13:29
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
July 15, 2021 15:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input arg modifier return maybe
该pr依赖#5451 ,
需要#5451 (OutputArgModifier_return_maybe_part_1分支)先合入