Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Nextcloud Bookmarks support #116

Closed
sunjam opened this issue Jan 28, 2018 · 8 comments
Closed

Request: Nextcloud Bookmarks support #116

sunjam opened this issue Jan 28, 2018 · 8 comments
Assignees
Milestone

Comments

@sunjam
Copy link

sunjam commented Jan 28, 2018

Hi,

This is a request for integrating support for Nextcloud Bookmarks, which is a fully open source, self-hosted bookmarks sync server using REST API.

@tladesignz
Copy link
Contributor

@m4mb01t4l14n0, I implemented a first shot at this:

In Bookmarks scene, press "Sync":

Simulator Screen Shot - iOS 12 4 @ iPhone 6 - 2020-02-27 at 10 06 24

Which brings you to this scene, where you can enter the server hostname, your username and password and then press "Synchronize" to do an initial synchronization.

As long as valid credentials are stored here, creation, edit and deletion of bookmarks will be synchronized to the server.

Do you feel this is a good-enough implementation, and if so, can @kckthx have a look at it and maybe improve the UI?

Simulator Screen Shot - iOS 12 4 @ iPhone 6 - 2020-02-27 at 10 09 47

@m4mb01t4l14n0
Copy link

@tladesignz great first shot at this!!! Question: Obviously this is a niche feature. It seems like exposing the Sync option to all users, therefore, might be asking for trouble. How about a setting (in Settings) that enables/disables Sync? If enabled, that action shows.

@kckthx we will likely have a set of smallish UX items for you this round. Let me collect those and analyze before you engage (since budget is small)

@tladesignz
Copy link
Contributor

tladesignz commented Feb 27, 2020

@tladesignz great first shot at this!!! Question: Obviously this is a niche feature. It seems like exposing the Sync option to all users, therefore, might be asking for trouble. How about a setting (in Settings) that enables/disables Sync? If enabled, that action shows.

Huh. That sounds like a lot of hiding. People won't be able to find it, unless they specifically search for that feature.

Nothing can happen in that scene, as long as they don't enter valid credentials to a Nextcloud server running the Bookmarks plugin. (They can't even press the "Synchronize" button, as long as they don't enter anything.)
Placing it there seemed logical (bookmarks...) and is a nice advertisement, I think.

@kckthx
Copy link
Collaborator

kckthx commented Mar 12, 2020

ok @tladesignz I've started working this out a bit and have a few questions

  1. What happens after the user taps “sync”? Will this screen have an option to “un-sync”? or “log out?”

  2. If the immediate sync fails, how would the user go about re-syncing? Do they have to un-sync their next cloud account and re-sync?

@tladesignz
Copy link
Contributor

  1. What happens after the user taps “sync”?
  1. All entries from the server are read.
  2. They are matched against the currently existing.
  3. If an entry is not existing locally, it is created.
  4. All entries from the device are created on the server, if they don't exist.

Will this screen have an option to “un-sync”? or “log out?”

No.

  1. If the immediate sync fails, how would the user go about re-syncing?

Just press "Sync" again.

Do they have to un-sync their next cloud account and re-sync?

No.

When bookmarks are created locally, they will be sent to the server immediately. If there's an error, then local and server are out-of-sync. No retries.

When a bookmark is deleted locally, it will be tried to delete it on the server, too.
If there's an error, local and server are out-of-sync. No retries.

So, if you press sync later, all locally-but-not-remotely deleted bookmarks come back.

I know, this is a very cheap implementation. I figured, we maybe try if this is enough, and see how the user feedback goes.
I'm not sure, if it's worth to throw a lot of work into a sync queue with retry mechanisms.
@m4mb01t4l14n0, what's your take on this?

@tladesignz
Copy link
Contributor

@kckthx, BTW: All of what I just rephrased is written in the scene itself. You can see it in the screenshots.

@kckthx
Copy link
Collaborator

kckthx commented Mar 18, 2020

ok @tladesignz here we go. I didn't rebuild out the bookmark screen since that's already done, so there's just a blank screen with "sync" at the bottom. ;)

I think the best move is to put the alert for a failed sync to be only seen when the sync actually fails, so it's less confusing.

OB-Sync_Nextcloud

@tladesignz
Copy link
Contributor

Thanks, @kckthx! Now implemented!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants