Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks -> Network-features only save if you exit with the button B #1611

Open
1 task done
Gammelstulle opened this issue Jun 19, 2024 · 3 comments
Open
1 task done
Labels
documentation Improvements or additions to documentation unable to reproduce Onion team have not been able to replicate the issue

Comments

@Gammelstulle
Copy link

Gammelstulle commented Jun 19, 2024

Checklist

  • I have reviewed the Onion Wiki and something is incorrect or missing

Wiki Section

https://onionui.github.io/docs/network-features

Description

Please add to the documentation of Samba, FTP, HTTP, (and all other network-features) that you NEED to press B to exit and save changes.
If you otherwise long press the Menu button instead, your changes will not save.
TBH I was so confused why my settings I made for the "network-features" are not saved after set end exit via Menu button. Especially as changes like "show expert mode" to "On" are saved just fine if you exit via the menu button. (So maybe this could be also a bug in 0.0.4.3)

I would also make a feature request, that long press the menu button to exit saves changes of all settings in tweaks. (It is just a bit inconsistent the way how it is right now)

Correction

(add this to any network feature doc ore just add it to your FAQ)

Save changes

Go back to the tweaks main menu.
Exit tweaks with B to apply & start the network-features XY

Provide any additional context or information that may help us with this update

No response

@Gammelstulle Gammelstulle added the documentation Improvements or additions to documentation label Jun 19, 2024
@Aemiii91
Copy link
Member

I'll look into it. You shouldn't have to long press menu for it to exit (a single short press should be enough)

@Gammelstulle
Copy link
Author

Gammelstulle commented Jun 19, 2024

I'll look into it. You shouldn't have to long press menu for it to exit (a single short press should be enough)

Yikes. I newbie, I use onion since 1 day x.x but love it a lot :).

@Aemiii91 Aemiii91 added the unable to reproduce Onion team have not been able to replicate the issue label Jun 23, 2024
@Aemiii91
Copy link
Member

Saves fine for me, when pressing MENU after changing a toggle in Tweaks -> Network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation unable to reproduce Onion team have not been able to replicate the issue
Projects
None yet
Development

No branches or pull requests

2 participants