Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong typing on AlertOptions interface #2354

Closed
rangelfinal opened this issue Feb 19, 2018 · 0 comments
Closed

Wrong typing on AlertOptions interface #2354

rangelfinal opened this issue Feb 19, 2018 · 0 comments

Comments

@rangelfinal
Copy link

rangelfinal commented Feb 19, 2018 •
edited
Loading

Environment 

[Core] onsenui 2.9.2

Encountered problem
The buttonLabels property on the AlertOptions interface on core/src/onsenui.d.ts should be typed as string[2] or [string, string], not [string].
Even the default value of ["Cancel", "OK"] wouldn't fit on [string].
https://github.com/OnsenUI/OnsenUI/blob/master/core/src/onsenui.d.ts#L1128
@lock lock bot added the outdated label May 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rangelfinal