Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC Client] Add a way to generically handle request for the default process data #485

Open
ad3154 opened this issue Jul 26, 2024 · 0 comments · May be fixed by #486
Open

[TC Client] Add a way to generically handle request for the default process data #485

ad3154 opened this issue Jul 26, 2024 · 0 comments · May be fixed by #486
Assignees
Labels
enhancement New feature or request iso: task controller Related to the ISO-11783:10 standard

Comments

@ad3154
Copy link
Member

ad3154 commented Jul 26, 2024

Is your feature request related to a problem? Please describe.
This is related to a discussion in the discord.

Basically, if a user wants to specify a default time interval for a given process data variable, we currently don't expose a way to set one, so if a TC server doesn't command a specific time interval, the client is just out of luck.

Describe the solution you'd like
We should have some callback of some kind where, when the default process data is requested, we loop through the DDOP to find objects that are part of the default process data set, and for each one, allow the user to enable any triggers they want or mark them as needing to have their initial value sent, or both.

Describe alternatives you've considered
There's probably a few different ways to implement this... a callback like the request_value_command_callback , or maybe some pure virtual interface that needs to be passed into the object. Lot of options. Callback might be the most consistent with how we're doing other things at the moment.

Another option would be to have the users pass in all the possible data when constructing the DDOP, but that seems less desirable, because if we accept a binary DDOP, there'd still be no way to set it.

Additional context
Discord context

@ad3154 ad3154 added enhancement New feature or request iso: task controller Related to the ISO-11783:10 standard labels Jul 26, 2024
@ad3154 ad3154 self-assigned this Jul 26, 2024
@ad3154 ad3154 linked a pull request Jul 27, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iso: task controller Related to the ISO-11783:10 standard
Projects
None yet
1 participant