Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor plugin architecture #2315

Open
ReimarBauer opened this issue Apr 10, 2024 · 1 comment
Open

refactor plugin architecture #2315

ReimarBauer opened this issue Apr 10, 2024 · 1 comment
Milestone

Comments

@ReimarBauer
Copy link
Member

ReimarBauer commented Apr 10, 2024

plugins may need modules we not have in MSS packaged, which might increase the size of the package
The navaid plugin was for that reason not packaged with MSS
https://mss.readthedocs.io/en/stable/plugins.html

currently we have only IO plugins, but also dockingwidgets maybe designed as plugins.

our flake8 checker finds

mslib/plugins/io/__init__.py:0:1: A005 the module is shadowing a Python builtin module "io"
mslib/plugins/io/csv.py:0:1: A005 the module is shadowing a Python builtin module "csv"

When we refactor this we also need a migration script for the users used msui_settings.json

A new solution should be enable not only IO plugins.

Afterwards setup.cfg needs a cleanup.

@ReimarBauer
Copy link
Member Author

related #1108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant