Maximal number of output points

[PavelBal]

The number of output points (in the OutputSchema) is restricted to 5000. This value is a great limitation when simulating months (or even years). I think this value should be increased (or even exposed as an input parameter).

[msevestre]

This value is set in core not in simmodel I believe

[Yuri05]

Yes, it's in core. SimModel does not have any restrictions regarding the number of points

OSPSuite.Core/src/OSPSuite.Core/Serialization/SimModel/DTO/OutputSchemaExport.cs

Lines 25 to 36 in 23c54c7

	public int NumberOfTimePoints
	{
	get
	{
	if (StartTime == EndTime)
	return Constants.MIN_NUMBER_OF_POINTS_PER_INTERVAL; //just a single point
	return Math.Min(
	Math.Max(Constants.MIN_NUMBER_OF_POINTS_PER_INTERVAL, (int) Math.Round(Resolution * (EndTime - StartTime)) + 1),
	Constants.MAX_NUMBER_OF_POINTS_PER_INTERVAL);
	}
	}

[PavelBal]

Constants.MIN_NUMBER_OF_POINTS_PER_INTERVAL should be an input parameter in solver settings. What do you think?

[msevestre]

Yep. I like it

[Yuri05]

MAX_NUMBER_OF_POINTS_PER_INTERVAL 😉

The restriction of 5000 points was introduced long time ago - before we had the possibility to restrict the number of stored time courses, before different memory optimizations (e.g. storing constant time courses with just 1 value) and having the total memory limit of 2 GB per application. Now with all those improvements the 5000 points limit can be drastically increased.

I would not define max number of points as an additional parameter. Instead I would either

• drop this limitation completely
• or set it as per default to a much higher value. When simulating over 1 year with the standard resolution 4 pts/h you would end up with ca. 35000 points. Thus if we set the limit to 100000 - you could simulate over almost 3 years with the standard resolution. If you need longer simulation time - either you accept lower resolution (is it really required to simulate with 4pts/h over 20 years?) or you could split your simulation time interval into several subintervals (each subinterval up to 3 years).

[msevestre]

Fine with me too

[msevestre]

Let's just remove it. PR coming