Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AllStateVariableParameterPathsIn to OSPSuite.R #1021

Merged
merged 2 commits into from
May 11, 2021
Merged

Add AllStateVariableParameterPathsIn to OSPSuite.R #1021

merged 2 commits into from
May 11, 2021

Conversation

PavelBal
Copy link
Member

Fixes #1020

@PavelBal PavelBal requested a review from msevestre May 11, 2021 12:21
msevestre
msevestre requested changes May 11, 2021
View reviewed changes
Copy link
Member

@msevestre msevestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a simple test retrieving one to make sure it's covered?

src/OSPSuite.R/Services/ContainerTask.cs Outdated
@@ -117,6 +121,8 @@ public IParameter[] AllParametersForSensitivityAnalysisMatching(ISimulation simu

private bool isRealContainer(IContainer container) => !container.IsAnImplementationOf<IDistributedParameter>() && !container.IsAnImplementationOf<IMoleculeAmount>();

private bool isStateVariableParameter(IParameter parameter) => !(parameter.RHSFormula == null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter.RHSFormula!=null

@PavelBal
Copy link
Member Author

Can you also add a simple test retrieving one to make sure it's covered?

Does the fake simulation used in tests has a state variable parameter at all? I am not sure... And definitely don't know how to add one :D

@msevestre
Copy link
Member

ok I'll add it then

@PavelBal
Copy link
Member Author

Thanks.

@PavelBal
Copy link
Member Author

@msevestre please do not merge yet.

msevestre
msevestre reviewed May 11, 2021
View reviewed changes
tests/OSPSuite.R.Tests/Services/ContainerTaskSpecs.cs
@@ -282,4 +287,22 @@ public void should_return_the_expected_path()
_result.ShouldOnlyContain(expected);
}
}

public class When_returning_all_state_variable_parameters_from_a_given_container : concern_for_ContainerTask
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PavelBal FYI

@msevestre msevestre merged commit 808504f into develop May 11, 2021
@msevestre msevestre deleted the get-state-variables branch May 11, 2021 14:30
@msevestre
Copy link
Member

@msevestre please do not merge yet.

sorry @PavelBal did not see this

@msevestre
Copy link
Member

Please create another issue if you need to add more feature to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msevestre msevestre msevestre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R: return paths of all state variable parameters
2 participants
@PavelBal @msevestre