-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AllStateVariableParameterPathsIn to OSPSuite.R #1021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a simple test retrieving one to make sure it's covered?
@@ -117,6 +121,8 @@ public IParameter[] AllParametersForSensitivityAnalysisMatching(ISimulation simu | |||
|
|||
private bool isRealContainer(IContainer container) => !container.IsAnImplementationOf<IDistributedParameter>() && !container.IsAnImplementationOf<IMoleculeAmount>(); | |||
|
|||
private bool isStateVariableParameter(IParameter parameter) => !(parameter.RHSFormula == null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameter.RHSFormula!=null
Does the fake simulation used in tests has a state variable parameter at all? I am not sure... And definitely don't know how to add one :D |
ok I'll add it then |
Thanks. |
@msevestre please do not merge yet. |
@@ -282,4 +287,22 @@ public void should_return_the_expected_path() | |||
_result.ShouldOnlyContain(expected); | |||
} | |||
} | |||
|
|||
public class When_returning_all_state_variable_parameters_from_a_given_container : concern_for_ContainerTask |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PavelBal FYI
sorry @PavelBal did not see this |
Please create another issue if you need to add more feature to this |
Fixes #1020