Fixes #1338 add capability for on evnet to deal with tasks #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Oct 13, 2021
| public static Task DoWithinExceptionHandler(this object callerObject, Func<Task> actionToExecute) | ||
| => DoWithinExceptionHandler(actionToExecute); | ||
|
|
||
| public static async Task DoWithinExceptionHandler(this Func<Task> actionToExecute) |
There was a problem hiding this comment.
The function of this types are defined in BTS.Utility. We can move them there eventually but I want to make sure the signature works as expected first
msevestre
commented
Oct 13, 2021
| /// and ensures that the <see cref="NotifyViewChanged" /> methods is being called if the | ||
| /// <paramref name="notifyViewChanged" /> is set to true | ||
| /// </summary> | ||
| protected virtual void OnEvent(Func<Task> action, bool notifyViewChanged = false) |
There was a problem hiding this comment.
Why do we need this? More and more, presenter method will return Task or Task instead of void or T. The current OnEvent helpers in our UI components do not support this. I am adding some to see if this is enough
msevestre
commented
Oct 13, 2021
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| namespace OSPSuite.Core.Extensions | |||
| { | |||
| public abstract class concern_for_FunctioExtensions : ContextSpecification<Func<int, int>> | |||
| public abstract class concern_for_FunctionExtensions : ContextSpecification<Func<int, int>> | |||
|
@ALL: This is going to be bumped to v11 for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.