-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1338 add capability for on evnet to deal with tasks #1340
Conversation
public static Task DoWithinExceptionHandler(this object callerObject, Func<Task> actionToExecute) | ||
=> DoWithinExceptionHandler(actionToExecute); | ||
|
||
public static async Task DoWithinExceptionHandler(this Func<Task> actionToExecute) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function of this types are defined in BTS.Utility. We can move them there eventually but I want to make sure the signature works as expected first
/// and ensures that the <see cref="NotifyViewChanged" /> methods is being called if the | ||
/// <paramref name="notifyViewChanged" /> is set to true | ||
/// </summary> | ||
protected virtual void OnEvent(Func<Task> action, bool notifyViewChanged = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? More and more, presenter method will return Task or Task instead of void or T. The current OnEvent helpers in our UI components do not support this. I am adding some to see if this is enough
@@ -4,7 +4,7 @@ | |||
|
|||
namespace OSPSuite.Core.Extensions | |||
{ | |||
public abstract class concern_for_FunctioExtensions : ContextSpecification<Func<int, int>> | |||
public abstract class concern_for_FunctionExtensions : ContextSpecification<Func<int, int>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yuri05 Should be bump to 10.1 ?
@ALL: This is going to be bumped to v11 for now |
No description provided.