Should be possible to switch between different parameter identification feedback views #1403

abdelr · 2021-12-17T11:49:13Z

Fixes #1372 (Should be possible to switch between different parameter identification feedback views )

msevestre · 2021-12-28T12:25:26Z

...senters/ParameterIdentifications/MultipleParameterIdentificationFeedbackPresentersManager.cs

+      IParameterIdentificationFeedbackPresenter FeedbackPresenterFor(ParameterIdentification parameterIdentification);
+   }
+
+   public class MultipleParameterIdentificationFeedbackPresentersManager : IMultipleParameterIdentificationFeedbackPresentersManager


Why is it called MultipleParameterIdentificationFeedbackPresentersManager and not ParameterIdentificationFeedbackPresentersManager

msevestre · 2021-12-28T12:25:42Z

...senters/ParameterIdentifications/MultipleParameterIdentificationFeedbackPresentersManager.cs

+
+   public class MultipleParameterIdentificationFeedbackPresentersManager : IMultipleParameterIdentificationFeedbackPresentersManager
+   {
+      static private IContainer _container;


Why is this static? remove

and use resharped to create it as readonly etc..

msevestre · 2021-12-28T12:26:16Z

...senters/ParameterIdentifications/MultipleParameterIdentificationFeedbackPresentersManager.cs

+   public class MultipleParameterIdentificationFeedbackPresentersManager : IMultipleParameterIdentificationFeedbackPresentersManager
+   {
+      static private IContainer _container;
+      private Cache<ParameterIdentification, IParameterIdentificationFeedbackPresenter> _currentParameterIdentifications = new Cache<ParameterIdentification, IParameterIdentificationFeedbackPresenter>();


this should also be readonly. Please run resharper to do this stuff for yoy automatically

msevestre · 2021-12-28T12:27:05Z

...senters/ParameterIdentifications/MultipleParameterIdentificationFeedbackPresentersManager.cs

+
+      public IParameterIdentificationFeedbackPresenter FeedbackPresenterFor(ParameterIdentification parameterIdentification)
+      {
+         if (_currentParameterIdentifications.Contains(parameterIdentification))


I fear that this might be called from multiple threads no? Should it be thread safe?

msevestre · 2021-12-28T12:28:19Z

...Presentation/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackPresenter.cs

      IListener<ParameterIdentificationIntermediateResultsUpdatedEvent>,
      IListener<ProjectClosedEvent>
   {
      bool ShouldRefreshFeedback { get; set; }
+      void OnParameterIdentificationStarted(ParameterIdentification parameterIdentification);


OnXxx looks like an event handler but it not. Why not just call it ParmaeterIdentificationStarted?

msevestre · 2021-12-28T12:29:24Z

...Presentation/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackPresenter.cs

@@ -142,6 +130,7 @@ public void Handle(ProjectClosedEvent eventToHandle)
         clearFeedbackReferences();
         resetFeedback();
         _view.NoFeedbackAvailable();
+         _view.Hide();


Why do you had the view? the user won't see that the PI is finished or even see the optimal results etc... or am i missing something?

If you close the project, should we keep the view open? To me, closing the project means you are finished with everything on it, including checking if the PI has finished or not. Actually, the references will be cleared meaning you should not be able to keep the view opened, right?

yeah ok. makes sense. What was the current behaviour? It would just stay open?

msevestre

Looks good. A few questions and reshaper should be run to format the file properly

abdelr · 2022-01-03T09:27:40Z

Looks good. A few questions and reshaper should be run to format the file properly

I have just fixed the problem with resharper so I hope there will not be any further problem with it anymore ;)

msevestre · 2022-01-03T10:10:30Z

...tion/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackPresentersManager.cs

+      {
+         lock (_locker)
+         {
+            _currentParameterIdentifications.Clear();


You are holding a reference all the IParameterIdentificationFeedbackPresenters here.
They need to be ReleaseFrom explicitly as they are registered in the EventPublisher on construction. This is a memory leak

so something like
_currentParameterIdentifications.Each(x=>x.ReleaseFrom(_eventPublisher)); where _eventPublisher is injected into the constructor of the Manager

I am wondering if ApplicationController is not doing the work already?

public virtual ISingleStartPresenter Open<TSubject>(TSubject subject, ICommandCollector commandCollector) { var presenterToOpen = PresenterFor(subject); if (presenterToOpen == null) { presenterToOpen = CreatePresenterForSubject(subject); presenterToOpen.Closing += removePresenter; presenterToOpen.InitializeWith(commandCollector); _allOpenedPresenters.Add(presenterToOpen); } return presenterToOpen; }

You are not resolving the presenter usting the applicationController but you are using the container.

But this is in fact a good point. I am wondering if we need this ParameterIdentifiactionManager at all since we already have everything in the applicationController. Why aren't you using this?

Yeah the ApplictionController does exactly what you need I feel for almost everything. Let's talk about it during the call later today

msevestre · 2022-01-03T10:10:57Z

src/OSPSuite.Presentation/UICommands/ParameterIdentificationFeedbackViewVisibilityUICommand.cs

      {
-         _feedbackPresenter = feedbackPresenter;
+         _multipleParameterIdentificationFeedbackPresentersManager = multipleParameterIdentificationFeedbackPresentersManager;


rename this variable to match type

msevestre

There is a leak that I missed on first pass

msevestre · 2022-01-03T10:21:46Z

The build is failing for some reasons...

abdelr · 2022-01-04T09:50:10Z

@msevestre There was already a ISingleStartPresenter registered to edit a ParameterIdentification so I needed to create a wrapper (ParameterIdentificationFeedback) for the ParameterIdentificationFeedbackView/Presenter. Additionally I needed a manager which will always return the same object for the same ParameterIdentification and add some "registrations". I actually do not like fully the code in MoBiApplicationController with the long if else for resolving a presenter for a subject. I would prefer to use the self aware pattern we discussed recently (we ask the presenters if they know how to handle the subject instead of having a long list with all the bindings, but I do not want to draw my attention now on this direction. Maybe for the future? In any case, I am still solving some unforeseen issues. I will let you know when this is finished.

msevestre · 2022-01-04T12:19:33Z

...e.Presentation/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackManager.cs

+      public void Handle(ParameterIdentificationStartedEvent eventToHandle)
+      {
+         var parameterIdentification = eventToHandle.ParameterIdentification;
+         lock (_locker)


Call GetFeedback method here (or to follow nomenclature rename it to FeedbackFor) instead of duplicating the code.

msevestre · 2022-01-04T12:22:06Z

...Presentation/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackPresenter.cs

+
+      public void Edit(ParameterIdentificationFeedback objectToEdit)
+      {
+         _key = objectToEdit;


I don't understand why you need this. Can't you save the _parameterIndentification as member?

msevestre · 2022-01-04T12:22:42Z

...Presentation/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackPresenter.cs

+      {
+         _key = objectToEdit;
+         if (objectToEdit.Running)
+            Handle(new ParameterIdentificationStartedEvent(objectToEdit.ParameterIdentification));


This is also very weird. THis is not how the publisher works. Want to have a call?

msevestre

I don't understand why you need this new Object structure. Let's have a chat

abdelr · 2022-01-04T12:40:51Z

I will call you in about 20 minutes.

msevestre

You mentioned a leak when clsoing. It is still missing right?

…en cancelled before opening the presenter

msevestre · 2022-01-05T08:42:15Z

...Presentation/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackPresenter.cs

+               setParameterIdentificationToStarted(objectToEdit.ParameterIdentification);
+               break;
+            case RunStatusId.Canceled:
+               setParameterIdentificationToStarted(objectToEdit.ParameterIdentification);


This is weird. Why start and then cancel. I am sure there is a reason but I would comment this in the code

msevestre · 2022-01-05T08:43:26Z

...Presentation/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackPresenter.cs

-         _parameterIdentification = eventToHandle.ParameterIdentification;
-         _view.Caption = Captions.ParameterIdentification.FeedbackViewFor(_parameterIdentification.Name);
-         showParameterIdentificationFeedback();
+         if (eventToHandle.ParameterIdentification != _parameterIdentificationFeedback.ParameterIdentification)


Much better. You even have a _parameterIdentification member so this could be
if (!Equals(_parameterIdentification , eventToHandle.ParameterIdentification))
return;

Same later. on public void Handle(ParameterIdentificationTerminatedEvent eventToHandle)

msevestre · 2022-01-05T08:43:53Z

...Presentation/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackPresenter.cs

+         //Nothing to do here
+      }
+
+      public void Edit(ParameterIdentificationFeedback objectToEdit)


rename objectToEdit to parameterIdentificationFeedback

msevestre

Minor changes. Looks very good. The onky really required is the comment to explain why you call the start on cancel. The rest is more for consistency purposes. Fix what you see fit and please merge

msevestre · 2022-01-05T11:10:15Z

...Presentation/Presenters/ParameterIdentifications/ParameterIdentificationFeedbackPresenter.cs

+               // event is triggered after a started event was triggered and the feedback view
+               // should evolve through both of them. If terminated is invoked directly, then the
+               // view would should its initial state asking the user to start the parameter identification
+               // instead of showing the terminated parameter identification and its last state.


msevestre · 2022-01-05T11:24:49Z

The build if failing @abdelr Can you check?

Implenting logic/test to handle different presenters

88e94bf

abdelr requested review from msevestre, Yuri05 and georgeDaskalakis December 17, 2021 11:49

abdelr self-assigned this Dec 17, 2021

abdelr added 2 commits December 17, 2021 13:08

Update MultipleParameterIdentificationFeedbackPresentersManagerSpecs.cs

371ff8a

Create new fake on every resolve call

868643c

msevestre reviewed Dec 28, 2021

View reviewed changes

msevestre requested changes Dec 28, 2021

View reviewed changes

abdelr added 3 commits January 3, 2022 10:32

Renaming for better readability and adding thread safety

b953b2e

Missing files on last commit

ad6fa7a

Missing files on last commit

0f9f59a

abdelr requested a review from msevestre January 3, 2022 09:33

msevestre reviewed Jan 3, 2022

View reviewed changes

msevestre requested changes Jan 3, 2022

View reviewed changes

abdelr added 4 commits January 3, 2022 13:42

Renaming variable to match type

d5a587a

Update MultipleParameterIdentificationFeedbackPresentersManagerSpecs.cs

dac1f84

partial commit for testing dll on MoBi

cce0c93

Fixing tests

c688ddb

abdelr added 2 commits January 4, 2022 12:03

Use manager as a singleton

5cb8379

do not throw

91e4d26

abdelr added 2 commits January 4, 2022 12:09

Manager on its own file

df8408f

Keeping track even before presenter is opened

a6b2c50

abdelr requested a review from msevestre January 4, 2022 11:50

msevestre reviewed Jan 4, 2022

View reviewed changes

msevestre requested changes Jan 4, 2022

View reviewed changes

Reuse methods and better naming

406d491

abdelr requested a review from msevestre January 4, 2022 13:57

msevestre reviewed Jan 4, 2022

View reviewed changes

abdelr added 2 commits January 4, 2022 21:00

Removing manager from presenter and handling the case where pi has be…

97d1867

…en cancelled before opening the presenter

Fixing test

b5fa4c2

abdelr requested a review from msevestre January 4, 2022 20:14

msevestre reviewed Jan 5, 2022

View reviewed changes

Adding explanation and direct reference

ac0969a

abdelr requested a review from msevestre January 5, 2022 11:07

msevestre reviewed Jan 5, 2022

View reviewed changes

msevestre approved these changes Jan 5, 2022

View reviewed changes

should not use _parameterIdentification before setting its value

1eedb3c

abdelr requested a review from msevestre January 5, 2022 11:56

msevestre merged commit 23c54c7 into develop Jan 5, 2022

msevestre deleted the 1372_Switching_parameter_identification_feedback_views branch January 5, 2022 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Should be possible to switch between different parameter identification feedback views #1403

Should be possible to switch between different parameter identification feedback views #1403

abdelr commented Dec 17, 2021

msevestre Dec 28, 2021

msevestre Dec 28, 2021

msevestre Dec 28, 2021

msevestre Dec 28, 2021

msevestre Dec 28, 2021

msevestre Dec 28, 2021

msevestre Dec 28, 2021

abdelr Jan 3, 2022

msevestre Jan 3, 2022

msevestre left a comment

abdelr commented Jan 3, 2022

msevestre Jan 3, 2022

abdelr Jan 3, 2022

msevestre Jan 3, 2022

msevestre Jan 3, 2022

msevestre Jan 3, 2022

msevestre left a comment

msevestre commented Jan 3, 2022

abdelr commented Jan 4, 2022 •

edited

Loading

msevestre Jan 4, 2022

msevestre Jan 4, 2022

msevestre Jan 4, 2022

msevestre left a comment

abdelr commented Jan 4, 2022

msevestre left a comment

msevestre Jan 5, 2022

msevestre Jan 5, 2022

msevestre Jan 5, 2022

msevestre left a comment

msevestre Jan 5, 2022

msevestre commented Jan 5, 2022

Should be possible to switch between different parameter identification feedback views #1403

Should be possible to switch between different parameter identification feedback views #1403

Conversation

abdelr commented Dec 17, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msevestre left a comment

Choose a reason for hiding this comment

abdelr commented Jan 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msevestre left a comment

Choose a reason for hiding this comment

msevestre commented Jan 3, 2022

abdelr commented Jan 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msevestre left a comment

Choose a reason for hiding this comment

abdelr commented Jan 4, 2022

msevestre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msevestre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msevestre commented Jan 5, 2022

abdelr commented Jan 4, 2022 •

edited

Loading