Do not prompt for close on import #1462
Conversation
|
What does the view.CloseOnImport do? Why is the presenter asking the view to trigger the close? This feels weird. Also needs test |
| @@ -41,10 +41,13 @@ public ModalImporterPresenter(IModalImporterView view, IImporterPresenter import | |||
| AddSubPresenters(importerPresenter); | |||
| } | |||
|
|
|||
| private bool _shouldPromtBeforeClose = false; | |||
There was a problem hiding this comment.
move the definition of this flag at the top (use resharper) and correct typo (Prompt)
| _importerPresenter.OnTriggerImport += (s, d) => | ||
| { | ||
| _shouldPromtBeforeClose = false; | ||
| _view.CloseOnImport(); |
There was a problem hiding this comment.
Oh see. This methods already exists and it is called CloseView.
From the name it looked it was triggering some event.. (Onxxx) .Naming is really everything in programming :)
There was a problem hiding this comment.
"There are only two hard things in Computer Science: cache invalidation and naming things"?
Phil Karlton
😅
|
@msevestre the test is not valid because the view.Display() method returns immediately. So, this is a blocking scenario. I have some ideas on how to implement this but I wonder if we already have some support for it. We could talk later about it if you want. |
|
A few remarks: |
|
We still do not have a cancel button, but I am not sure if we want to change this. In any case, if we do, it will be just adding the button which will invoke form close but keep in mind that we already have some buttons changing captions and could be a bit confusing. We have the X button anyways. Behavior seems to work properly now... close -> prompt, import -> close silently |
Fixes #1460 (Do not prompt for close on import)