-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset mapping before loading configuration #1467
Reset mapping before loading configuration #1467
Conversation
@@ -404,6 +404,8 @@ public void LoadConfigurationWithoutImporting() | |||
if (confirmDroppingOfLoadedSheets()) | |||
return; | |||
|
|||
onResetMappingBasedOnCurrentSheet(this, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onResetMappingBasedOnCurrentSheet does not use either e nor null. Can I suggest to remove the argument in this mehtod, call in resetMappingBasedOnCurrentSheet and in the event registration, do (o, e)=> eesetMappingBasedOnCurrentSheet()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right
[Observation] | ||
public void must_reset_format_based_on_current_sheet() | ||
{ | ||
(sut as ImporterPresenterForTest).OnResetMappingBasedOnCurrentSheetInvoked.ShouldBeTrue(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion so that we do not call a method that is an event handler with weird aguments
Fixes #1459 (Reset mapping before loading configuration)