Fixes #1464 throw when running the same twice #1468
Conversation
| /// <param name="cancellationToken">Cancellation token to cancel the threads</param> | ||
| /// <param name="numberOfCoresToUse">Number of cores to use. Use null to take all cores</param> | ||
| /// <returns>Dictionary binding a result for each input data after running the action on it</returns> | ||
| Task RunAsync<TData>( |
There was a problem hiding this comment.
@abdelr As discussed. Thanks for the suggestion
| { | ||
| var id = generateId(); | ||
| simulationBatchRunValues.Id = id; |
There was a problem hiding this comment.
I am moving the creation of the Id to the object itselft...
| return _concurrencyManager.RunAsync( | ||
| batches, | ||
| //Use {} to specify using the overload without return value | ||
| (batch, ct) => { batch.AddNewBatch(); }, |
There was a problem hiding this comment.
This is the only downside of using the same name... I need to use the {} to that it picks the right overload
| @@ -186,19 +189,30 @@ public void should_import_simple_data_from_csv() | |||
| } | |||
|
|
|||
| [Observation] | |||
| public void should_return_empty_on_invalid_file_name() | |||
| [TestCase("IntegrationSample1.csv", 2)] | |||
| [TestCase("sample_non_existent.csv", 2)] | |||
There was a problem hiding this comment.
oups... this does not belong here!
|
@msevestre Tests are failing |
|
|
||
| _simulationBatch1.AddSimulationBatchRunValues(_parValues1); | ||
| _simulationBatch2.AddSimulationBatchRunValues(_parValues1); |
There was a problem hiding this comment.
Adding the same object multiple time is not allowed anymore... unique ids
| new ConcurrencyManagerResult<TResult>(datum.Id, action(datum, cancellationToken)) | ||
| ); | ||
| } | ||
| catch (Exception e) |
There was a problem hiding this comment.
You removed the try/catch. This was here to make sure that if one run fails (running one simulation throws an exception for example) the rest are still recorded. Like this I think you would not be able to return anything at all. Right?
There was a problem hiding this comment.
yep. But here we have no way of knowing which one failed as we have no identifier.
|
Tests are running again. This was the wrong file commited. |
No description provided.