Update ParameterIdentificationFeedbackViewVisibilityUICommand.cs #1486
Conversation
|
yes much better. This would have created. a leak the way it was before because the PI was not cleared anyways |
|
|
||
| namespace OSPSuite.Presentation.UICommands | ||
| { | ||
| public class ParameterIdentificationFeedbackViewVisibilityUICommand : ObjectUICommand<IParameterIdentificationFeedbackPresenter>, IListener<ParameterIdentificationSelectedEvent> | ||
| public class ParameterIdentificationFeedbackViewVisibilityUICommand : ObjectUICommand<IParameterIdentificationFeedbackPresenter> |
There was a problem hiding this comment.
there is in fact a better UI command for this. ActveSubjectUIComand. Can you use this insteaD?
There was a problem hiding this comment.
ActveSubjectUIComand
I did not find ActveSubjectUIComand but instead I found ActiveObjectUICommand. The problem is that we need the command to implement ObjectUICommand but retrieve a ParameterIdentification as the active subject. So if I would extend ActiveObjectUICommand the Subject will be of type IParameterIdentificationFeedbackPresenter which is not what I need. To avoid this, I would need to change IParameterIdentificationFeedbackManager so it uses the cache based on the presenter, and not the object. This will imply to make the presenter to have a public getter for the object so we can access the object from the Subject (presenter). Do you like these changes?
There was a problem hiding this comment.
I don't understand. Why can't you be ActiveObjectUICommand?
There was a problem hiding this comment.
It was about making the ParameterIdentification public on the presenter interface (IParameterIdentificationFeedbackPresenter). Sorry the description was not that clear. Check changes on the code for easier understanding.
There was a problem hiding this comment.
I am sorry but I don't understand how this works. Can we have a call?
There was a problem hiding this comment.
I am sorry but I don't understand how this works. Can we have a call?
@msevestre Just call any time
msevestre
deleted the
1372_Using_ActiveSubjectRetriever_to_detect_active_parameter_identification
branch
Fixes #1372 (Using ActiveSubjectRetriever to retrieve the active parameter identification instead of listening to events)