Fixes #1821 comma decimal separator #1840
Conversation
| /// </summary> | ||
| char? GetCsvSeparator(string fileName); | ||
| CSVSeparators GetCsvSeparator(string fileName); |
There was a problem hiding this comment.
feels like a good usage of named tuples here. (not required but simple API instead of having a class etc.)
| private char _decimalSeparator; | ||
| public int PreviewLineCount => 5; | ||
|
|
||
| public void SetColumnSeparator(char selectedSeparator) |
There was a problem hiding this comment.
ugly. thius should be binding with DTO
| { | ||
| separatorComboBoxEdit.Properties.Items.Add(separator); | ||
| } | ||
| columnSeparatorComboBoxEdit.Properties.Items.AddRange(_columnSeparatorList); |
There was a problem hiding this comment.
This fixes the issue so I am only going to put it as a suggestion for another time. We should have a DTO, a binding and not do all this settings, EditValueChanged etc by hand. Use the framework.
/cc @georgeDaskalakis Not sure if you implemented this. Much better to use the screenbinder for these use cases
| @@ -48,7 +49,6 @@ public void path_is_set() | |||
| sut.Path.ShouldBeEqualTo(_csvFilePath); | |||
| } | |||
|
|
|||
|
|
|||
| [TestCase] | |||
There was a problem hiding this comment.
Observation and not testcase. Damn
|
|
||
| protected override string ExtractLloq(string description, DataSheet dataSheet, List<string> keys, ref double rank) | ||
| public override string Name => "Mixin"; | ||
| public override string Description => "https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/639\rhttps://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/797"; |
There was a problem hiding this comment.
@rwmcintosh
Where is this description shown?
I wonder why it points to the Github-issues and not to the docu:
https://docs.open-systems-pharmacology.org/shared-tools-and-example-workflows/import-edit-observed-data#supported-formats
| private const string _description = "https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/639"; | ||
| public override string Name { get; } = _name; | ||
| public override string Name => "Headers with units"; | ||
| public override string Description => "https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/639"; |
There was a problem hiding this comment.
@rwmcintosh Same question: why not to the docu?
| public override string Name => _name; | ||
| public override string Description => _description; | ||
| public override string Name => "Nonmem"; | ||
| public override string Description => "https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/797"; |
There was a problem hiding this comment.
@rwmcintosh Same question: why not to the docu?
There was a problem hiding this comment.
Rob doesn't know. This comes from before lol
There was a problem hiding this comment.
where are those descriptions used - probably showed as a tooltip somewhere?
There was a problem hiding this comment.
@Yuri05 i didn't investigate the property usage. I only noticed that there were these unnecessary private fields that I wanted to remove.
No description provided.