-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1821 comma decimal separator #1840
Conversation
/// </summary> | ||
char? GetCsvSeparator(string fileName); | ||
CSVSeparators GetCsvSeparator(string fileName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like a good usage of named tuples here. (not required but simple API instead of having a class etc.)
private char _decimalSeparator; | ||
public int PreviewLineCount => 5; | ||
|
||
public void SetColumnSeparator(char selectedSeparator) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugly. thius should be binding with DTO
{ | ||
separatorComboBoxEdit.Properties.Items.Add(separator); | ||
} | ||
columnSeparatorComboBoxEdit.Properties.Items.AddRange(_columnSeparatorList); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue so I am only going to put it as a suggestion for another time. We should have a DTO, a binding and not do all this settings, EditValueChanged etc by hand. Use the framework.
/cc @georgeDaskalakis Not sure if you implemented this. Much better to use the screenbinder for these use cases
@@ -48,7 +49,6 @@ public void path_is_set() | |||
sut.Path.ShouldBeEqualTo(_csvFilePath); | |||
} | |||
|
|||
|
|||
[TestCase] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observation and not testcase. Damn
|
||
protected override string ExtractLloq(string description, DataSheet dataSheet, List<string> keys, ref double rank) | ||
public override string Name => "Mixin"; | ||
public override string Description => "https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/639\rhttps://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/797"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwmcintosh
Where is this description shown?
I wonder why it points to the Github-issues and not to the docu:
https://docs.open-systems-pharmacology.org/shared-tools-and-example-workflows/import-edit-observed-data#supported-formats
private const string _description = "https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/639"; | ||
public override string Name { get; } = _name; | ||
public override string Name => "Headers with units"; | ||
public override string Description => "https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/639"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwmcintosh Same question: why not to the docu?
public override string Name => _name; | ||
public override string Description => _description; | ||
public override string Name => "Nonmem"; | ||
public override string Description => "https://github.com/Open-Systems-Pharmacology/OSPSuite.Core/issues/797"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwmcintosh Same question: why not to the docu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rob doesn't know. This comes from before lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are those descriptions used - probably showed as a tooltip somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yuri05 i didn't investigate the property usage. I only noticed that there were these unnecessary private fields that I wanted to remove.
No description provided.