Fixes #909 aging data for calculation #910
Conversation
|
|
||
| namespace OSPSuite.R.Domain | ||
| { | ||
| public class AgingData |
There was a problem hiding this comment.
@Yuri05 It's very hard to create DataTable and have them usable in R
So I created this very stupid class that will need to be instantiated in R (via a wrapper)
|
|
||
| public interface ISimulationRunner | ||
| { | ||
| Task<SimulationResults> RunAsync(SimulationRunArgs simulationRunArgs); |
There was a problem hiding this comment.
@Yuri05 It always take some times to remember that rClr does not work well with optional parameters. I am creating an object argument instead
| /// InQuotes(test) => "test" | ||
| /// </example> | ||
| /// <param name="text">Text to encapsulate in quotes</param> | ||
| public static string InQuotes(this string text) => $"\"{text}\""; |
There was a problem hiding this comment.
Should we check here that text does not contains (double) quotes?
At least in MoBi user can create parameters with double quotes in name; if such a parameter will be varied in a population, CSV export will be invalid then
Just created an iissue for that: Open-Systems-Pharmacology/MoBi#530
There was a problem hiding this comment.
"" should be forbidden from parameter names. Why is this allowed in the first place..no idea
No description provided.