Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace confusing observed data terminology nonmenColumn and nonmemUnit by datasetColumn and datasetUnit #534

Closed
sfrechen opened this issue Sep 13, 2021 · 3 comments

Comments

@sfrechen
Copy link
Member

The terminology is confusing. NONMEM is a proprietary software tool and stands for non-linear mixed effects modelling. First, it has nothing to do with data.

Please replace throughout the ReportingEngine:
nonmenColumn --> datasetColumn
nonmemUnit --> datasetUnit

(And yes, it is not a typo by me... it is currently written as "nonmenColumn"...)

Affected files (no warranty for completeness):

  • error-checks.R
  • messages.R
  • uitilities-observed-data.R
  • Excel Template (WorkflowInput.xlsx) -> Sheet "tpDictionary"

@Yuri05 @Christoph27 @AnnikaRPS

@Yuri05
Copy link
Member

Yuri05 commented Sep 14, 2021

@sfrechen do we need backward compatibility in the dictionaries? I mean: if the new column name is not found: should RE try to find the old column name?
E.g. if the "datasetUnit" column is missing: should RE look for the "nonmemUnit" column?
If yes: data dictionaries in existing RE workflows can be kept AS IS. Otherwise existing datadictionaries need to be adjusted for the new naming.

@sfrechen
Copy link
Member Author

I don't have any RE workflows for R ReportingEngine :-).
But I would guess if we fix it soon... there is virtually no impact since it hasn't been used in a productive way too often.
And to reproduce old results (if there are one), one needs to use anyway the corresponding ReportingEngine version.

Thus: I would say: no backward compatibility needed.

@msevestre
Copy link
Member

Thus: I would say: no backward compatibility needed.

WOOT WOOT!!

pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Sep 16, 2021
pchelle added a commit to pchelle/OSPSuite.ReportingEngine that referenced this issue Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants