[php-symfony] Symfony6 support

[sensorario]

Update php-symfony's generator template to work with Symfony6 and php8. fix #11322

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Hi @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @ybelenko, @renepardon! I've made this PR because I needed to generate php code from a swagger file. I am using Symfony8 and php8. Hope this Pull request is good enough or a starting point to improve the symfony support of this project.

[wing328]

@sensorario thanks for the PR. Is it correct to say that this is a breaking change? If that's case, should this PR target 6.0.x branch (breaking changes without fallback)?

[sensorario]

@wing328 yes. May I rebase into 6.0.x, ...

[sensorario]

@wing328 I think something went wrong. I checked out branch 6.0.x. I moved all my changes here. Recreated symfony6-support branch from here and then followed the steps

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

But now I see all samples generated.

[sensorario]

You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.

For this PR is goot just php-symfony or may I add all other updated examples?

[ybelenko]

Cool, finally someone ready to share modern Symfony build. Let me review, I want to test it locally before merge. Thanks @sensorario

[ybelenko]

Hmm, Symfony 6 requires php: >=8.0.2 and we should provide something for php 7.4(still supported until Nov 28, 2022). @wing328 what do you think, maybe keep the old version with creating new generator like php-symfony-6?

[wing328]

maybe keep the old version with creating new generator like php-symfony-6?

Sounds good to me.

[sensorario]

I guess something is not clear for me. I checked out 6.0.x to, started new branch from here. [...] Then, ... the command ./bin/generate-samples.sh fails. May I open new issue? Should the sequence

./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh

must works in 6.0.x branch?

[wing328]

@sensorario I've changed the PR target branch to "master" (which is the upcoming v6.0.0 release). Can you please resolve the merge conflicts when you've time?

[BenjaminHae]

Latest available version is 4.0.2
https://packagist.org/packages/jms/serializer-bundle

[BenjaminHae]

When requiring the package created using this PR with composer, the following error is returned:

PHP Fatal error:  Declaration of OpenAPI\Server\DependencyInjection\OpenAPIServerExtension::getAlias() must be compatible with Symfony\Component\DependencyInjection\Extension\Extension::getAlias(): string in DependencyInjection/OpenAPIServerExtension.php

I think the return value of getAlias must be string.

Additionally the version of jms/serializer-bundle required in composer.json is 6.0.x. The latest available version however is 4.0.2

[BenjaminHae]

Additionally, I think some work needs to be done for compatibility with the new JMS/Serializer version.
As a first step the changes introduced by this PR #10763 can be taken.
However this targets version 3.5. for version 4.0 some more work is needed.

[ybelenko]

Additionally, I think some work needs to be done for compatibility with the new JMS/Serializer version.
As a first step the changes introduced by this PR #10763 can be taken.
However this targets version 3.5. for version 4.0 some more work is needed.

Well, I thought this PR contains significant changes(when I noticed updated files list 😅), but it's just bump of the Symfony and PHP number. I'm afraid that we have to start Symfony 6 generator from scratch. I'm not even sure that current codegen builds and works.

@sensorario did you compare generator output with basic Symfony 6 skeleton(fresh installation)? I think they completely different.

[BenjaminHae]

@ybelenko I did the required changes to make it really work with symfony6 in #11810

[ybelenko]

@sensorario thanks for the effort. I'm closing PR without merge in favour of #11810 let's focus in the one thread.