Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kotlin-Spring] support to Spring boot3 & jakarta extension #13620

Closed
wants to merge 2 commits into from
Closed

[Kotlin-Spring] support to Spring boot3 & jakarta extension #13620

wants to merge 2 commits into from

Conversation

jayandran-Sampath
Copy link

Updated moustache files to support jakarta extension & spring boot 3

refer #13578

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

estigma88
estigma88 reviewed Oct 6, 2022
View reviewed changes
...ator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java
@@ -385,4 +385,33 @@ public void beanQualifiers() throws Exception {
"@RestController(\"org.openapitools.api.PingApiController\")"
);
}

@Test(description = "use Spring boot 3 & jakarta extension")
public void useSpringBoot3() throws Exception {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see several project examples inside samples/server/petstore but I don't see any example with jakarta, is that intended?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these file changes are intended as i modified import style for existing ones. unit test is covering jakarta imports validation and not sure on what basis framework generate sample project for different types

@wing328
Copy link
Member

wing328 commented Oct 15, 2022

cc @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@wing328 wing328 added this to the 6.2.1 milestone Oct 15, 2022
@wing328 wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022
@ravermeister ravermeister mentioned this pull request Nov 25, 2022
Closed
5 tasks
@ravermeister
Copy link

Looking forward to 6.3.0 🙂

DennisHartrampf
DennisHartrampf reviewed Dec 15, 2022
View reviewed changes
...es/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-boot/pom-sb3.mustache
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.0.0-M5</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 3.0.0 instead of 3.0.0-M5. Then I think also the Spring milestone repository can be removed.

@kinari321 kinari321 mentioned this pull request Dec 16, 2022
Merged
9 tasks
@varminas
Copy link

varminas commented Dec 21, 2022 •
edited
Loading

looking forward to 6.3.0

@deicon
Copy link
Contributor

deicon commented Dec 22, 2022

Any plans for this to be merged ? I have successfully tested this PR using multiple different projects. Anything missing here were I could help ?

@tuan1nguyen
Copy link

We are also looking forward to the upcoming release for migrating our Kotlin service to Spring Boot 3.

@parenko parenko mentioned this pull request Jan 2, 2023
Merged
5 tasks
@parenko
Copy link
Contributor

parenko commented Jan 4, 2023

@jayandran-Sampath do you need some help with merging?

@Wernerson
Copy link

Also looking forward to this feature :)
Any updates when this will get merged?

@jayandran-Sampath
Copy link
Author

@jayandran-Sampath do you need some help with merging?

Hey thanks for checking.. it would be great if you or anyone else help me to resolve conflicts.. due to personal reason, i could not work on this for now.. thanks

@wing328 wing328 modified the milestones: 6.3.0, 6.3.1 Jan 20, 2023
@parenko
Copy link
Contributor

parenko commented Jan 31, 2023

Your commits are meged. I think you can close this PR.

@wing328 wing328 modified the milestones: 6.4.0, 6.5.0 Feb 19, 2023
@wing328 wing328 modified the milestones: 6.5.0, 6.6.0 Apr 1, 2023
@wing328 wing328 modified the milestones: 6.6.0, 7.0.0 May 11, 2023
@wing328 wing328 closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisHartrampf DennisHartrampf DennisHartrampf left review comments

@estigma88 estigma88 estigma88 left review comments

Assignees
No one assigned
Labels
Enhancement: Compatibility Server: Kotlin Server: Spring
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet