-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin-Spring] support to Spring boot3 & jakarta extension #14369
Conversation
@parenko is this ready for merge? if yes, please mark is as "ready for review" |
@wing328 it was, just wanted to make sure that all checks passed, and then switch for review |
I've tried to regenerate the sample using the added By default currently, no Spring Boot 3 sample is generated given that it's behind a flag. I feel It'd be useful to have at last one generated so it becomes part of the main sample suite. What do you think? After all, it's a major version |
Also tested the unhappy sprinfox path, working as expected. Well done! |
Which open issue would this close BTW @parenko ? |
...enerator/src/main/resources/kotlin-spring/libraries/spring-boot/buildGradle-sb3-Kts.mustache
Outdated
Show resolved
Hide resolved
...enerator/src/main/resources/kotlin-spring/libraries/spring-boot/buildGradle-sb3-Kts.mustache
Show resolved
Hide resolved
@parenko can you give me your opinion on this comment :
I'm happy to do the commit. |
@jlengrand thank you for pointing this out to me. I think it is a good idea and useful. I tried your suggestion. Let me know if you would have done it similarly? |
I used wrong option in |
Hey @parenko. I went ahead and changed the option for you. I decided to stay consistent with the "use" keyword. If you merge https://github.com/parenko/openapi-generator/pull/1/files It should run fine. I also considered doing something like "springBootVersion = 3", with 2 being the default but I guess it's better to merge that now and consider it later (when is 4.x coming out anyways :)). As soon as https://github.com/parenko/openapi-generator/pull/1/files is merged (or the build runs fine), AFAIC it's good to go @wing328 |
Great job overall, it's clean, does what it's supposed to and you went the extra mile to test. Much appreciated |
@jlengrand, I have changed the |
I have used #13620 PR then just merged with master and fixed conflicts.
Also changed spring boot version in POM and Gradle.
Synchronized with Java generator options.
Additionally run generate samples for Kotlin and run export documentation.
Executed successfully
mvn clean compile
on following samples:To fix #13578
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)FYI @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)