-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to overwrite only changed files #1397
Conversation
…e option. Add unit test.
…illis() on Linux.
Thanks! Sometimes I get tripped up by gitflow. |
|
||
/** | ||
* Write bytes to a file | ||
* @param filename The name of file to write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nits] Please insert blank comment line between the description and the list of tags.
|
||
/** | ||
* Is the minimal-file-update option enabled? | ||
* @return Option value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nits] Please insert blank comment line between the description and the list of tags.
@SuppressWarnings("static-method") | ||
/** | ||
* Write String to a file, formatting as UTF-8 | ||
* @param filename The name of file to write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nits] Please insert blank comment line between the description and the list of tags.
* Add blank comment lines to satisfy PR feedback * Remove tabs
I've resolved the conflicts. 938e34a 😌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but needs to integrate master to resolve merge conflicts.
This PR can be closed? (#2451 has been merged) |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.4.x
,4.0.x
. Default:master
.Description of the PR
Cherry-picks comments from #1391
Credits go to @wheezil
Also cc @OpenAPITools/generator-core-team