Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for rust reqwest middleware client #13990

Merged
merged 9 commits into from
Nov 13, 2022
Merged

Add tests for rust reqwest middleware client #13990

merged 9 commits into from
Nov 13, 2022

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 11, 2022

Add tests for rust reqwest middleware client

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10)

pom.xml Show resolved Hide resolved
@jacob-pro
Copy link
Contributor

jacob-pro commented Nov 12, 2022

I'm kind of confused why these need to be added individually like this?
All the crates exist within the same workspaces:
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/rust/Cargo.toml
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/server/petstore/rust-server/Cargo.toml
So if you run cargo test within the root of the workspace it will run all unit and integration tests in all the sub crates

- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
toolchain: stable
Copy link
Contributor

@jacob-pro jacob-pro Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider setting an MSRV here, or ideally having a matrix of both MSRV and latest. Similar to:
https://github.com/actix/actix-web/blob/45b77c68195eb933231290a09e9f6a0cca56aad8/.github/workflows/ci.yml#L21-L23

And then if we only run clippy on the MSRV so we avoid the issues here:
#13907

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for sharing that. agreed with the matrix of both MSRV and the latest.

let's see if anyone has time to do it in a separate PR after merging this one.

wing328 and others added 3 commits November 12, 2022 10:09
Co-authored-by: Nathan Shaaban <86252985+nshaaban-cPacket@users.noreply.github.com>
@wing328 wing328 merged commit 4a5c9ff into master Nov 13, 2022
@wing328 wing328 deleted the rust-update-test branch November 13, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants