Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Spring] Fix #14398 springboot 3 schema required #14402

Merged
merged 3 commits into from Jan 14, 2023

Conversation

parenko
Copy link
Contributor

@parenko parenko commented Jan 8, 2023

Fix for #14398

Schema#required is deprecated since 2.2.5 and replaced by requiredMode.

OAS3 required parameter is of type boolean and defaults to false thus I used Schema.RequiredMode.NOT_REQUIRED when required is false.

I have checked following samples for compilation, such that min >= 2.2.5 swagger-annotations library is used.

  • samples/openapi3/client/petstore/spring-cloud-3/
  • samples/openapi3/client/petstore/spring-cloud-async/
  • samples/openapi3/client/petstore/spring-cloud-date-time/
  • samples/openapi3/client/petstore/spring-cloud-oas3-fakeapi/
  • samples/openapi3/client/petstore/spring-cloud-spring-pageable/
  • samples/openapi3/client/petstore/spring-cloud/
  • samples/openapi3/client/petstore/spring-stubs-skip-default-interface/
  • samples/openapi3/client/petstore/spring-stubs/
  • samples/openapi3/server/petstore/spring-boot-oneof/
  • samples/openapi3/server/petstore/spring-boot-springdoc/
  • samples/openapi3/server/petstore/springboot-3/
  • samples/openapi3/server/petstore/springboot-beanvalidation-no-nullable/
  • samples/openapi3/server/petstore/springboot-delegate/
  • samples/openapi3/server/petstore/springboot-implicitHeaders/
  • samples/openapi3/server/petstore/springboot-reactive/
  • samples/openapi3/server/petstore/springboot-useoptional/
  • samples/openapi3/server/petstore/springboot/
  • samples/server/petstore/java-camel/
  • samples/server/petstore/java-micronaut-server/pom.xml
  • samples/server/petstore/java-micronaut-server/
  • samples/server/petstore/spring-boot-defaultInterface-unhandledException/
  • samples/server/petstore/spring-boot-nullable-set/
  • samples/server/petstore/springboot-virtualan/

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/java-*
    ./bin/generate-samples.sh ./bin/configs/spring-*
    ./bin/generate-samples.sh ./bin/configs/kotlin-*
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@parenko parenko changed the title 14398 springboot 3 schema requred [Java][Spring] Fix #14398 springboot 3 schema required Jan 8, 2023
@parenko parenko force-pushed the 14398-springboot-3-schema-requred branch 3 times, most recently from 2c21c2e to 9dde82d Compare January 13, 2023 07:28
@parenko
Copy link
Contributor Author

parenko commented Jan 13, 2023

Notify technical committee:

Language Member
Java @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
Java Spring @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)
Kotlin @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@parenko parenko marked this pull request as ready for review January 13, 2023 13:24
@parenko parenko force-pushed the 14398-springboot-3-schema-requred branch from 9dde82d to 24aff39 Compare January 14, 2023 10:19
@parenko parenko requested a review from borsch January 14, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants