Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serializationLibrary option from Kotlin server generators #16627

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 20, 2023

Remove serializationLibrary option from Kotlin server generators

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@wing328 wing328 added this to the 7.1.0 milestone Sep 20, 2023
@wing328 wing328 merged commit 9b39887 into master Sep 20, 2023
18 checks passed
@wing328 wing328 deleted the kotlin-client-option branch September 20, 2023 09:06
@gnu9
Copy link

gnu9 commented Jul 9, 2024

Why did this change remove the serializationLibrary option from Kotlin server generators?

Adding the serializationLibrary option to the client makes sense, but removing it from the server generators?

As @svenallers noted in #13155, this change removed for the backend the support of e.g. the serializationLibrary which is used by the kotlin client generator via multiplatform option.

@wing328 could you please reply why the option was not kept for the server generators?
@nucle asked already in Feb. (#13155) why it was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants