[R] various bug fixes and enhancements #1965
Conversation
| result <- returnObject$fromJSON(httr::content(resp, "text", encoding = "UTF-8")) | ||
| Response$new(returnObject, resp) | ||
| {{/isPrimitiveType}} | ||
| {{^isPrimitiveType}} |
There was a problem hiding this comment.
@jokedurnez thanks for the PR. Seems like this line is missing a space in terms of alignment?
|
@jokedurnez thanks for the enhancement. Can you please also run the following to update the R Petstore samples? linux/mac: (you may notice changes not caused by this PR, which is fine) |
|
Fixed those review comments ! |
|
@jokedurnez shall we use 2-space for indentation as stated in https://google.github.io/styleguide/Rguide.xml#indentation ? |
|
Also I've started a project to refactor the R client generator and you can track progress in https://github.com/OpenAPITools/openapi-generator/projects/8 |
|
FYI. Filed #2215 to refactor the R client. |
| {{/isListContainer}} | ||
| {{/vars}} | ||
| ) | ||
| gsub("[\r\n]| ", "", outstring) |
There was a problem hiding this comment.
I think this may cause issues if the value contains these characters
* debug headers in R client * fixes to R client * petstore samples * missing space * other space :)
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
I cleaned up the mustache files to be more readable, fixed the primary types and added conditionals to responses.
Used for this specification: https://github.com/openlattice/api/blob/develop/openlattice.yaml
Thanks for the great resource !