[C++] Adjust the names (script, sample folder, generator) to lang option #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkrwork
requested changes
Jun 5, 2018
|
Looks good to me too! Thanks for the contribution! |
|
@stkrwork Thanks for your comment! fixed it. 👷 |
|
Oh, I noticed that the scripts also exists under bin/openapi3. 👀 |
|
Looks good to me. |
stkrwork
requested changes
Jun 6, 2018
There was a problem hiding this comment.
you already mentioned that the scripts in bin/openapi3 also require changing
added 2 commits
June 7, 2018 09:06
cpp-restsdk is not exist under bin/openapi3
|
Fixed the scripts under bin/openapi3. |
|
Did you also look at the restbed and pistache scripts, our C++ servers? |
|
Oh... I didn't know that restbed and pistache is C++ generator as I'm pretty new to C++. 💦 Thanks for pointing it out. ✨ |
|
We can do the pistache and restbed with a different PR. I also forgot. |
|
I'll file a different PR fixes the issue. 💪 |
4 tasks
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jun 8, 2018
* master: Add 'unblu inc.' to company list (OpenAPITools#246) put company list in alphabetical order (OpenAPITools#244) [jaxrs-spec] generate spec file (yaml) correctly (OpenAPITools#243) [C++] Adjust the names (script, sample folder, generator) to lang option (OpenAPITools#220) Add GMO Pepabo to company list (OpenAPITools#242) [Spring] Add apiFirst option (OpenAPITools#184) [cli] Write to stdout/stderr, allow redirection (OpenAPITools#207) [JAVA][Client] New object instead of null for empty POST request (OpenAPITools#98) Make yaml serialization deterministic (OpenAPITools#233) Add syntax highlighting to migration guide (OpenAPITools#237) Fix shippable badge (OpenAPITools#232) update company list (OpenAPITools#227) Fix OpenAPITools#210: [Ada] Update the code generator for required and optional parameters (OpenAPITools#211) Delete unused methods in DefaultCodegen (OpenAPITools#209) add note about maven plugins (OpenAPITools#216) add raiffeisen to company list (OpenAPITools#223) add a remark about homebrew installatio (OpenAPITools#217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master.Description of the PR
Related issue: #138 (comment)
This PR prefixes the scripts/sample folders/generators with
cpp-to avoid users/contributors be confused.