[JAVA][Client] New object instead of null for empty POST request #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff9finger
approved these changes
May 24, 2018
|
Because the "ci/circleci" if failing for some download failed errors: I have tried to run the java sample locally. This is not working for me: I get these compile errors: The reset-assured project on Because of the review delay (sorry about that), can you also merge |
jmini
requested changes
May 25, 2018
| @@ -623,146 +623,146 @@ public TestEndpointParametersOper(RequestSpecBuilder reqSpec) { | |||
| return handler.apply(RestAssured.given().spec(reqSpec.build()).expect().spec(respSpec.build()).when().request(POST, REQ_URI)); | |||
| } | |||
|
|
|||
| public static final String INTEGER_FORM = "integer"; | |||
| public static final String _FORM = "integer"; | |||
|
By the way to test locally all java clients, I am using a pom file that looks like this: <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>tmp</groupId>
<artifactId>tmp-build-root</artifactId>
<packaging>pom</packaging>
<version>1.0.0-SNAPSHOT</version>
<modules>
<module>samples/client/petstore/java/feign/</module>
<module>samples/client/petstore/java/google-api-client/</module>
<module>samples/client/petstore/java/jersey1/</module>
<module>samples/client/petstore/java/jersey2-java6/</module>
<module>samples/client/petstore/java/jersey2-java8/</module>
<module>samples/client/petstore/java/jersey2/</module>
<module>samples/client/petstore/java/okhttp-gson-parcelableModel/</module>
<module>samples/client/petstore/java/okhttp-gson/</module>
<module>samples/client/petstore/java/rest-assured/</module>
<module>samples/client/petstore/java/resteasy/</module>
<module>samples/client/petstore/java/resttemplate-withXml/</module>
<module>samples/client/petstore/java/resttemplate/</module>
<module>samples/client/petstore/java/retrofit/</module>
<module>samples/client/petstore/java/retrofit2-play24/</module>
<module>samples/client/petstore/java/retrofit2/</module>
<module>samples/client/petstore/java/retrofit2rx/</module>
<module>samples/client/petstore/java/retrofit2rx2/</module>
</modules>
</project> |
|
Thanks @jmini |
I see this in the logs: @bmordue: what is your workflow when you create the commit "Ran bin/java-petstore-all.sh again". It is not documented, but it should be:
Then the check in Shippable will be OK. |
…rator into new-object-empty-request
|
Commit c30afdf fixes the Shippable build. Can you please merge |
|
I have merged |
jmini
approved these changes
Jun 7, 2018
wing328
approved these changes
Jun 7, 2018
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jun 8, 2018
* master: Add 'unblu inc.' to company list (OpenAPITools#246) put company list in alphabetical order (OpenAPITools#244) [jaxrs-spec] generate spec file (yaml) correctly (OpenAPITools#243) [C++] Adjust the names (script, sample folder, generator) to lang option (OpenAPITools#220) Add GMO Pepabo to company list (OpenAPITools#242) [Spring] Add apiFirst option (OpenAPITools#184) [cli] Write to stdout/stderr, allow redirection (OpenAPITools#207) [JAVA][Client] New object instead of null for empty POST request (OpenAPITools#98) Make yaml serialization deterministic (OpenAPITools#233) Add syntax highlighting to migration guide (OpenAPITools#237) Fix shippable badge (OpenAPITools#232) update company list (OpenAPITools#227) Fix OpenAPITools#210: [Ada] Update the code generator for required and optional parameters (OpenAPITools#211) Delete unused methods in DefaultCodegen (OpenAPITools#209) add note about maven plugins (OpenAPITools#216) add raiffeisen to company list (OpenAPITools#223) add a remark about homebrew installatio (OpenAPITools#217)
|
This pull request is causing an error, that originated issue #513: now an empty Object is being set as request body on every request (not only POST requests) and by default message converters don't know how to treat empty Objects, throwing the exception Before this pull request, when post objects were null by default, this error did not happen. |
|
@rubms I was about to write the same problem. By setting 'postBody' to 'new Object' the RestTemplate.doWithRequest() does not jump into the first if block in line 829. It now jumps into the block to where it tries to serialize the body (Within a GET request) |
4 tasks
|
I just created the #605 pull request in order to get this fixed. |
|
I'm concerned. Why aren't there tests to cover this? Simple GET/PUT/POST for every library should be mandatory! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master.Description of the PR
It's safer to initialize the request body to an empty Object instead of null if there are no body parameters. In particular, this allows Jackson to successfully serialize a POST request with no body parameters when the Content-Type header is set to "application/json, which is set by default.
See swagger-api/swagger-codegen#7551 for more context -- bringing this over to
openapi-generatorcc @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger