Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin] client improvement / remove WildCards in client/server #2862

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
2 participants
@karismann
Copy link
Contributor

commented May 10, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @jimschubert (2017/09) , @dr4ke616 (2018/08) @Zomzog (2019/04)

Description of the PR

Kotlin Client + Server :

  • fix some default value in docs
  • remove wildcard imports (fix #1401)

Kotlin Client :

  • update dependencies (kotlin, okhttp3, threetenbp)
  • post form request : use contenttype defined in spec
  • don't override content-type/accept if defined in spec
  • handle empty json response (actually Moshi throw a EOF Exception)
  • add missing CI test (updatePetWithForm, deletePet)

@karismann karismann closed this May 10, 2019

@karismann karismann reopened this May 10, 2019

@wing328
Copy link
Member

left a comment

LGTM

@wing328 wing328 merged commit ef26ce6 into OpenAPITools:master May 11, 2019

3 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
Shippable Run 7857 status is SUCCESS.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wing328 wing328 added this to the 4.0.0 milestone May 11, 2019

@karismann karismann deleted the karismann:kotlin-client-improve branch May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.