Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin][client] small improvements #9640

Merged
merged 6 commits into from
Jun 2, 2021

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Jun 1, 2021

This PR makes the following small improvements:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@@ -16,17 +16,17 @@ import com.squareup.moshi.ToJson
import java.net.URI

{{#moshi}}
{{#nonPublicApi}}internal {{/nonPublicApi}}class UriAdapter {
{{#nonPublicApi}}internal {{/nonPublicApi}}class URIAdapter {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. Android refers to Uri instead: https://developer.android.com/reference/kotlin/android/net/Uri

I see that you want to keep it consistent with the file name that I'm totally ok with.

@wing328
Copy link
Member

wing328 commented Jun 2, 2021

LGTM

@wing328 wing328 merged commit 0f51662 into OpenAPITools:master Jun 2, 2021
@4brunu 4brunu deleted the feature/kotlin-uri branch June 2, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants