Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Https protocol schema is not handled correctly in java 11 native code #3730

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

thecrazzymouse
Copy link
Contributor

…e code #3729

  • added getter for schema

@macjohnny
Copy link
Member

cc @bbdouglas

@macjohnny
Copy link
Member

@thecrazzymouse thanks for the PR.
could you please re-generate the samples and commit them? see https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md

@macjohnny
Copy link
Member

@thecrazzymouse could you please re-generate the samples and commit them? see https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny
Copy link
Member

ci failure is unrelated (kotlin samples)

@macjohnny macjohnny merged commit 73eae09 into OpenAPITools:master Aug 23, 2019
@thecrazzymouse thecrazzymouse deleted the fix_3729 branch August 23, 2019 11:53
jimschubert added a commit that referenced this pull request Aug 25, 2019
* master: (45 commits)
  update python samples
  Two tiny fixes for Java Vertx client (#3683)
  Exclude "test" from packages so that it is not installed as top-level package when "pip installing" the generated sdk (#3731)
  [java-client] add unit test for JDK 11 HttpClient (#3735)
  [R] feat(r): handling error response for 3xx cases (#3571)
  [Dart] Avoid redundant null checking in fromJson (#3632)
  [core] Set isMultipart=true for multipart operations, fix possible NPE (#3750)
  reenable kotlin client tests in shippable ci (#3751)
  Fix null assignation to header/query param map (#3749)
  Mockito 3.0.0 (#3732)
  Update to swagger-parser to 2.0.14-OpenAPITools.org-1 (#3737)
  Add a link to a Qiita blog post (#3747)
  update csharp samples
  Simple spelling error in dotnet core comments (#3746)
  better support for multipart (#3736)
  [typescript-fetch] fix #1998: prefix req ifaces. (#3740)
  cpp-qt5-client: add valgrind memory test (#3663)
  [typescript-angular] Encode objects for multipart/form-data with json - fixes #2733 (#3738)
  [BUG] Https protocol schema is not handled correctly in java 11 native code #3729 (#3730)
  comment out kotlin client tests
  ...
@wing328 wing328 changed the title [BUG] Https protocol schema is not handled correctly in java 11 nativ… [BUG] Https protocol schema is not handled correctly in java 11 native code Aug 26, 2019
@wing328
Copy link
Member

wing328 commented Aug 26, 2019

@thecrazzymouse thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants