Update to swagger-parser to 2.0.14-OpenAPITools.org-1 #3737
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
pom.xml
Outdated
| @@ -271,6 +271,7 @@ | |||
| </requireMavenVersion> | |||
| <requireReleaseDeps> | |||
| <message>No Snapshots Allowed!</message> | |||
| <onlyWhenRelease>true</onlyWhenRelease> | |||
There was a problem hiding this comment.
REMOVE THIS LINE when we switch to a released version!
|
The CI jobs looks good to me.
I have just created the release: It will appear on maven central soon. I will update this PR when the jars are on Maven Central. |
jmini
changed the title
| @@ -791,6 +791,7 @@ paths: | |||
| properties: | |||
| integer: | |||
| description: None | |||
| format: int32 | |||
There was a problem hiding this comment.
I don't think these changes are related to the PR?
There was a problem hiding this comment.
Oh I see you updated the samples, nevermind then!
There was a problem hiding this comment.
I guess either Swagger-Parser is setting those (explicit default), or Swagger-Core has a new behavior.
IMO this is an acceptable change.
| @@ -726,6 +726,7 @@ paths: | |||
| properties: | |||
| integer: | |||
| description: None | |||
| format: int32 | |||
There was a problem hiding this comment.
FYI. Our petstore (fake) spec does not specify the format. I think swagger parser now defaults format to int32 for integer type if no format is specified.
Not sure if the community welcomes this change. We'll see.
* master: (45 commits) update python samples Two tiny fixes for Java Vertx client (#3683) Exclude "test" from packages so that it is not installed as top-level package when "pip installing" the generated sdk (#3731) [java-client] add unit test for JDK 11 HttpClient (#3735) [R] feat(r): handling error response for 3xx cases (#3571) [Dart] Avoid redundant null checking in fromJson (#3632) [core] Set isMultipart=true for multipart operations, fix possible NPE (#3750) reenable kotlin client tests in shippable ci (#3751) Fix null assignation to header/query param map (#3749) Mockito 3.0.0 (#3732) Update to swagger-parser to 2.0.14-OpenAPITools.org-1 (#3737) Add a link to a Qiita blog post (#3747) update csharp samples Simple spelling error in dotnet core comments (#3746) better support for multipart (#3736) [typescript-fetch] fix #1998: prefix req ifaces. (#3740) cpp-qt5-client: add valgrind memory test (#3663) [typescript-angular] Encode objects for multipart/form-data with json - fixes #2733 (#3738) [BUG] Https protocol schema is not handled correctly in java 11 native code #3729 (#3730) comment out kotlin client tests ...
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Update the Swagger-Parser version to
2.0.14-OpenAPITools.org-1Previous PR #3239