Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][CORE] Repaired Checkstyle #4029

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@Fjolnir-Dvorak
Copy link
Contributor

commented Oct 2, 2019

LeftCurly had invalid attribute maxLineLength. Also removed the redundant RightCurly.

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

LeftCurly had invalid attribute maxLineLength. Also removed the redundant RightCurly.
@Fjolnir-Dvorak Fjolnir-Dvorak changed the title Repaired Checkstyle [CORE] Repaired Checkstyle Oct 2, 2019
@Fjolnir-Dvorak Fjolnir-Dvorak changed the title [CORE] Repaired Checkstyle [FIX][CORE] Repaired Checkstyle Oct 2, 2019
@wing328 wing328 added this to the 4.1.3 milestone Oct 3, 2019
@wing328 wing328 merged commit 5c24a54 into OpenAPITools:master Oct 3, 2019
5 checks passed
5 checks passed
Shippable Run 10913 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Fjolnir-Dvorak Fjolnir-Dvorak deleted the Fjolnir-Dvorak:patch-1 branch Oct 3, 2019
Jesse0Michael added a commit to Jesse0Michael/openapi-generator that referenced this pull request Oct 3, 2019
LeftCurly had invalid attribute maxLineLength. Also removed the redundant RightCurly.
Jesse0Michael added a commit to Jesse0Michael/openapi-generator that referenced this pull request Oct 3, 2019
LeftCurly had invalid attribute maxLineLength. Also removed the redundant RightCurly.
@wing328

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

@Fjolnir-Dvorak thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

jimschubert added a commit that referenced this pull request Oct 6, 2019
* master: (35 commits)
  [haskell-http-client] update samples (#4073)
  [haskell-http-client] Bump deps to LTS 14.7 (#4068)
  update release for 4.2.0
  [typescript-axios] Fix api generating incorrect seralization type check (#4051)
  prepare 4.1.3 release (#4052)
  typescript-node: form data file (#3967)
  Add a link to blog post on vertx and openapi (#4048)
  better wording for apiNameSuffix option description (#4045)
  [Ruby] fix ruby test, update error message (#4041)
  [PHP] Correctly format JSON in headers (#4024)
  [haskell-http-client] add dateTimeParseFormat cli option - overrides the format string used to parse a datetime (#4037)
  Add frankyjuang to the C# technical committee (#4036)
  Feature/api name suffix (#3918)
  [F#] minor improvements to the generators (#3968)
  Repaired Checkstyle (#4029)
  mockito 3.1.0 (#4035)
  typescript-fetch: fix return type of primitive value (#4028)
  [typescript][node]: Add accept header if produces is not empty (#3966)
  [haskell-http-client] disable unused import warning in Core.hs (#4020)
  Add a link to the tutorial in http4k (#4019)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.