Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin] Fix (de)serialization of enum classes #7917

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

cschramm
Copy link
Contributor

While inner enum classes from dataClass.mustache work fine, standalone enum classes lack @JsonProperty annotations so that Jackson uses names instead of values.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

@wing328 wing328 added this to the 5.0.0 milestone Nov 23, 2020
@wing328 wing328 modified the milestones: 5.0.0, 5.0.1 Dec 21, 2020
@wing328 wing328 modified the milestones: 5.0.1, 5.1.0 Feb 8, 2021
@wing328
Copy link
Member

wing328 commented Mar 6, 2021

Can you please merge the latest master into your branch and update the samples by running the following?

./mvnw clean package 
./bin/generate-samples.sh

While inner enum classes from dataClass.mustache work fine, standalone enum classes lack `@JsonProperty` annotations so that Jackson uses names instead of values.
@cschramm
Copy link
Contributor Author

cschramm commented Mar 6, 2021

Done. Those commands did not have any visible effect on the repository, though.

@wing328 wing328 merged commit 4a63aae into OpenAPITools:master Apr 16, 2021
@wing328 wing328 added this to the 5.1.1 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants