[Kotlin] Fix (de)serialization of enum classes (kotlinx serialization) #9143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum class which are inside the dataClass.mustache file are missing the
Serializable
annotation. This leads to a wrong behavior of the serializer where the names instead of the the SerialName values are used.You can reproduce this issue if you run the
kotlin-retrofit2-kotlinx_serialization
sample project. A warning likeExplicit @Serializable annotation on enum class is required when @SerialName or @SerialInfo annotations are used on its members.
will be thrown.The changeset also adds the Xopt-in compiler flags for the
ExperimentalSerializationApi
which also leads to compiler warnings.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m