-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] fix deprecation warnings #8969
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
@@ -1011,18 +1011,18 @@ public class ApiClient { | |||
public RequestBody serialize(Object obj, String contentType) throws ApiException { | |||
if (obj instanceof byte[]) { | |||
// Binary (byte array) body parameter support. | |||
return RequestBody.create(MediaType.parse(contentType), (byte[]) obj); | |||
return RequestBody.create((byte[]) obj, MediaType.parse(contentType)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far as I can tell, this has introduced a regression in the Java generator - see #9151.
In 5.0.1 the generated line in `ApiClient` was: ``` return RequestBody.create(MediaType.parse(contentType), (byte[]) obj); ``` in 5.1.0 it is: ``` return RequestBody.create((byte[]) obj, MediaType.parse(contentType)); ``` Looks like this change was introduced in OpenAPITools#8969, and requires a more recent version of OkHttp to compile in some (all?) circumstances.
In 5.0.1 the generated line in `ApiClient` was: ``` return RequestBody.create(MediaType.parse(contentType), (byte[]) obj); ``` in 5.1.0 it is: ``` return RequestBody.create((byte[]) obj, MediaType.parse(contentType)); ``` Looks like this change was introduced in #8969, and requires a more recent version of OkHttp to compile in some (all?) circumstances.
@@ -1272,7 +1272,7 @@ public class ApiClient { | |||
reqBody = null; | |||
} else { | |||
// use an empty request body (for POST, PUT and PATCH) | |||
reqBody = RequestBody.create(MediaType.parse(contentType), ""); | |||
reqBody = RequestBody.create("", MediaType.parse(contentType)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why has this been swapped?
I'm getting errors that there is no such method signature found in okhttp client 4.9.1.
RequestBody.create()
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)