Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][okhttp] Bump OkHTTP dependency to latest #9353

Conversation

toby-murray-snow-software
Copy link
Contributor

@toby-murray-snow-software toby-murray-snow-software commented Apr 27, 2021

In 5.0.1 the generated line in ApiClient was:

return RequestBody.create(MediaType.parse(contentType), (byte[]) obj);

in 5.1.0 it is:

return RequestBody.create((byte[]) obj, MediaType.parse(contentType));

Looks like this change was introduced in #8969, and requires a more recent version of OkHttp to compile in some (all?) circumstances.

I tested out the failing spec that was mentioned in the linked ticket, and it compiles now.

To fix #9151

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

In 5.0.1 the generated line in `ApiClient` was:
```
return RequestBody.create(MediaType.parse(contentType), (byte[]) obj);
```
in 5.1.0 it is:
```
return RequestBody.create((byte[]) obj, MediaType.parse(contentType));
```

Looks like this change was introduced in OpenAPITools#8969, and requires a more recent version of OkHttp to compile in some (all?) circumstances.
@wing328
Copy link
Member

wing328 commented Apr 28, 2021

Tested locally and the result is good.

@wing328 wing328 merged commit 83adc06 into OpenAPITools:master Apr 28, 2021
@wing328 wing328 changed the title [java][okhttp] Fixes #9151: Bump OkHTTP dependency to latest [java][okhttp] Bump OkHTTP dependency to latest Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Java] ApiClient.java: error: no suitable method found for create(byte[],MediaType)
2 participants