Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart][ci] Move Dart samples from CircleCI to Github actions #9515

Merged
merged 5 commits into from
May 21, 2021

Conversation

kuhnroyal
Copy link
Contributor

@kuhnroyal kuhnroyal commented May 18, 2021

Suggestions/Assumptions

  • future release branches (5.2.x) should be named release/5.2.x or some use different pattern that can be globbed in the workflow files
  • there should be a separate workflow for Samples of each platform/language

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@kuhnroyal kuhnroyal marked this pull request as ready for review May 18, 2021 20:25
@kuhnroyal
Copy link
Contributor Author

@wing328 This also fixes a new formatting CI failure due to yesterdays Flutter/Dart release which now gets installed in CircleCI.

@kuhnroyal
Copy link
Contributor Author

When separating this into actions, there is actually no more need to run these samples via Maven at all.

* use fixed version to prevent flaky builds
@wing328
Copy link
Member

wing328 commented May 21, 2021

Both drone.io, travis CI failures have been fixed in the master.

@wing328 wing328 merged commit b8c5a64 into OpenAPITools:master May 21, 2021
@wing328 wing328 added this to the 5.2.0 milestone May 21, 2021
@kuhnroyal kuhnroyal deleted the dart/ci branch May 21, 2021 08:08
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
…Tools#9515)

* [dart] Move Dart samples from CircleCI to Github actions

* Fix format failing with latest Dart version

* Workflow naming

* Split dart samples depending on version

* use fixed version to prevent flaky builds

* Change branch pattern for release branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants