Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Can't access certain crypto.dd functions from SDK #3884

Closed
djl0 opened this issue Jan 6, 2023 · 2 comments · Fixed by #3888
Closed

[Bug] Can't access certain crypto.dd functions from SDK #3884

djl0 opened this issue Jan 6, 2023 · 2 comments · Fixed by #3888
Labels
bug Fix bug crypto Crypto related

Comments

@djl0
Copy link

djl0 commented Jan 6, 2023

Apologies if I'm just missing something, but I cannot seem to access crypto dd score and dev from the SDK. They do not appear in dir(openbb.crypto.dd). I'm having a hard time tracing this back with the Breadcrumbs() structure. Given they appear in due_diligence_api.py I would have expected them to be accessible.

Thanks!

@github-actions github-actions bot added bug Fix bug crypto Crypto related labels Jan 6, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Jan 7, 2023

Yup. Nice catch. These have not made their way in. They need to be mapped to their model functions in miscellaneous/library/trail_map.csv.

We are still dotting our i's and crossing our t's with getting every terminal function mapped, so thanks for helping us stop some more!

@jmaslek
Copy link
Collaborator

jmaslek commented Jan 7, 2023

So actually I am seeing most of the cg functions in crypto.dd aren't in the sdk and the reason is that they aren't following the MVC convention and these functions actual do the model functions in the view, so we dont have the correct way of mapping to the model -- because there is no model.

I think I have a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug crypto Crypto related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants