Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sunset some dependencies #4215

Merged
merged 7 commits into from
Feb 13, 2023
Merged

Sunset some dependencies #4215

merged 7 commits into from
Feb 13, 2023

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Feb 10, 2023 •
edited
Loading

This PR removes the following deps from our tree:

  • sentiment-investor : unused
  • investpy : api has not recovered from months ago
  • investiny : same as above
  • pyEx: unmaintained, unused and iex is deprecating the api it hits

@jmaslek jmaslek added the dependencies Work related to dependencies label Feb 10, 2023
@reviewpad reviewpad bot added the feat XL Extra Large feature label Feb 10, 2023
hjoaquim
hjoaquim approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Side question: the .md files for the website will be auto-regenerated, right?

@jmaslek
Copy link
Collaborator Author

jmaslek commented Feb 13, 2023

Looks good to me.

Side question: the .md files for the website will be auto-regenerated, right?

The reference docs will be, yes.

@jmaslek jmaslek added this pull request to the merge queue Feb 13, 2023
@jmaslek jmaslek removed this pull request from the merge queue due to a manual request Feb 13, 2023
jmaslek added a commit that referenced this pull request Feb 13, 2023
@jmaslek
Merge pull request #4215 from OpenBB-finance/feature/cleaning-up
280a5ed 
Sunset some dependencies
@jmaslek jmaslek merged commit 2a7ec56 into develop Feb 13, 2023
@jmaslek jmaslek deleted the feature/cleaning-up branch February 13, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

@Chavithra Chavithra Awaiting requested review from Chavithra

@piiq piiq Awaiting requested review from piiq

@montezdesousa montezdesousa Awaiting requested review from montezdesousa

Assignees
No one assigned
Labels
dependencies Work related to dependencies feat XL Extra Large feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaslek @hjoaquim