Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove matplotlib references #4479

Merged
merged 21 commits into from
Mar 15, 2023
Merged

Remove matplotlib references #4479

merged 21 commits into from
Mar 15, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Mar 14, 2023

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added the refactor Refactor code label Mar 14, 2023
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Mar 14, 2023
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat S Small T-Shirt size Feature labels Mar 14, 2023
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Mar 14, 2023
@montezdesousa montezdesousa marked this pull request as ready for review March 14, 2023 17:33
Copy link
Contributor

@tehcoderer tehcoderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here from

from openbb_terminal import OpenBBFigure
from openbb_terminal.core.plots.plotly_helper import theme

You can do this

from openbb_terminal import OpenBBFigure, theme

openbb_terminal/futures/databento_view.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@8bd7606). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4479   +/-   ##
==========================================
  Coverage           ?   54.53%           
==========================================
  Files              ?      596           
  Lines              ?    53482           
  Branches           ?        0           
==========================================
  Hits               ?    29165           
  Misses             ?    24317           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tehcoderer tehcoderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!! Lets gooooo 🚀🚀🚀

@montezdesousa montezdesousa added this pull request to the merge queue Mar 15, 2023
Merged via the queue into develop with commit b19dc52 Mar 15, 2023
@montezdesousa montezdesousa deleted the hotfix/mpl_refs branch March 15, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants