Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ultima platform integration for Pro #5639

Conversation

AdiSai
Copy link
Contributor

@AdiSai AdiSai commented Oct 31, 2023

This PR adds Ultima Insights as a provider to the obb.stocks.news() function

Examples:

obb.stocks.news('AAPL', provider='ultima').to_df()

and

obb.stocks.news('AAPL', provider='ultima').to_df()

Screenshot 2023-10-31 at 5 32 37 PM

@reviewpad reviewpad bot added the feat XL Extra Large feature label Oct 31, 2023
@AdiSai AdiSai changed the title Feature/ultima platform integration Feature/ultima platform integration for Pro Nov 1, 2023
@IgorWounds
Copy link
Contributor

Hi @AdiSai ,

Can you please change the version of your extension from a6 to a4 in pyproject.toml and bump the openbb-core from a2 to a5? Also, can you create the lock files using the poetry lock command? Please make sure the changes are reflected in the main pyproject.toml and dev_install.py scripts.

@reviewpad reviewpad bot added feat L Large T-Shirt size Feature and removed feat XL Extra Large feature labels Nov 8, 2023
@AdiSai
Copy link
Contributor Author

AdiSai commented Nov 8, 2023

Hi @AdiSai ,

Can you please change the version of your extension from a6 to a4 in pyproject.toml and bump the openbb-core from a2 to a5? Also, can you create the lock files using the poetry lock command? Please make sure the changes are reflected in the main pyproject.toml and dev_install.py scripts.

@IgorWounds I just pushed the latest changes. However on PyPi I have a6 published as the current version. Does that cause any issues considering I changed the version here to a4?

@piiq piiq mentioned this pull request Nov 8, 2023
@piiq
Copy link
Contributor

piiq commented Nov 8, 2023

@AdiSai I've picked it up and merged into the branch where some change in the naming has been applied. So i'll be closing this one in favour of #5684

Thanks for the contribution

@piiq piiq closed this Nov 8, 2023
@AdiSai AdiSai deleted the feature/Ultima-Platform-Integration branch November 14, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat L Large T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants