Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/contributing guidelines #5738

Closed
wants to merge 9 commits into from
Closed

Docs/contributing guidelines #5738

wants to merge 9 commits into from

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Nov 15, 2023 •
edited
Loading

Improving the contributing guidelines section on the website docs.

@hjoaquim hjoaquim added docs Code documentation platform OpenBB Platform labels Nov 15, 2023
@hjoaquim hjoaquim marked this pull request as ready for review November 15, 2023 13:27
@hjoaquim
Copy link
Contributor Author

@piiq I generated the keywords and descriptions with the help of Cursor. Is there any other custom process I should follow instead for an SEO optimized set of keywords and descriptions?

@deeleeramone
Copy link
Contributor

deeleeramone commented Nov 16, 2023 •
edited
Loading

@hjoaquim, this is good stuff. Let's port this over to the branch I'm working on. I've merged this PR into #5720.

I do have a question though, under Developer Guidelines we have Expectations for Developers, which is the same as Expectations for Contributors. As we have separated the personas here, are we under the assumption that developers are not going to be submitting PRs but are building on top for their own purposes?

@hjoaquim
Copy link
Contributor Author

@hjoaquim, this is good stuff. Let's port this over to the branch I'm working on. I've merged this PR into #5720.

I do have a question though, under Developer Guidelines we have Expectations for Developers, which is the same as Expectations for Contributors. As we have separated the personas here, are we under the assumption that developers are not going to be submitting PRs but are building on top for their own purposes?

As I view it, yes, that's it!

@hjoaquim
Copy link
Contributor Author

Closing this PR in favor of #5720.

@hjoaquim hjoaquim closed this Nov 16, 2023
@hjoaquim hjoaquim deleted the docs/contributing-guidelines branch November 16, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiq piiq Awaiting requested review from piiq

@deeleeramone deeleeramone Awaiting requested review from deeleeramone

Assignees
No one assigned
Labels
docs Code documentation platform OpenBB Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjoaquim @deeleeramone