-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Econ Calendar #6392
[BugFix] Econ Calendar #6392
Conversation
openbb_platform/providers/fmp/openbb_fmp/models/economic_calendar.py
Outdated
Show resolved
Hide resolved
openbb_platform/providers/tradingeconomics/openbb_tradingeconomics/models/economic_calendar.py
Show resolved
Hide resolved
@deeleeramone this looks good. For some reason I can't get tradingeconomics to work inside the CLI. Is this the same for you @deeleeramone ? cc: @hjoaquim |
So in the CLI I was getting:
Adding |
Don't we want the Literal to be Optional? Sending a None through the API does not always work and can break. @hjoaquim you already have some screenshots on this. |
openbb_platform/providers/tradingeconomics/openbb_tradingeconomics/models/economic_calendar.py
Outdated
Show resolved
Hide resolved
openbb_platform/providers/tradingeconomics/openbb_tradingeconomics/models/economic_calendar.py
Outdated
Show resolved
Hide resolved
openbb_platform/providers/tradingeconomics/openbb_tradingeconomics/models/economic_calendar.py
Outdated
Show resolved
Hide resolved
…minal into bugfix/econ-calendar
…nce/OpenBBTerminal into bugfix/econ-calendar
Started as needing to add the list of countries to
json_schema_extra
in the TradingEconomics model, but ran into other items needing to be taken care of.What?:
calendar_id
as a parameter for TE.Optional
from Literals and they now are proper choices in the API docs.group
parameter had one choice with a space in it.Impact:
calendar_id
country
parameter now has:json_schema_extra={"choices": COUNTRIES}
Testing Done:
Note that FMP does not have any query parameters other than start/end dates.