You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The secondary advantage comes when it's time to actually capture and utilize logs (#129), as having the dynamic values separated from the log boilerplate itself simplifies the parsing required.
Describe the solution you'd like
Do a full repo search for logging messages
Where possible, implement dynamic elements of log messages with lazy-formatted arguments
Update tests where possible to check args instead of the formatted message
Describe alternatives you've considered
Not doing this
Additional context
I could have sworn that doing this would break any tests, and that caplog[i].message was just the placeholders without the arguments, but if that was ever the case, it appears to be no longer. 🤷
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
A message that consistently comes up in the PyLint reports is:
There are, apparently, performance reasons for this suggestion, but for me, the primary advantage is that it makes tests much cleaner, e.g. 35854ba#diff-a908114b22e34b7043cbe4670c94a557cff7431a0818027a255607239c96cdb7
The secondary advantage comes when it's time to actually capture and utilize logs (#129), as having the dynamic values separated from the log boilerplate itself simplifies the parsing required.
Describe the solution you'd like
Describe alternatives you've considered
Not doing this
Additional context
I could have sworn that doing this would break any tests, and that
caplog[i].message
was just the placeholders without the arguments, but if that was ever the case, it appears to be no longer. 🤷The text was updated successfully, but these errors were encountered: