-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tof_binning as actual binning values #173
Comments
Could you also put this in the documentation of binning (the binning.rst file) when a PR is created? |
I would say it does not really belong there, at it is not related to the binning we do, but to the binning that was applied to the data by the detector readout. But it should go to the documentation, I agree. I will see where. |
We will discuss details about this during the Beamtime, and figure out what the correct parameters for FLASH should be. |
Closed by PR #451 |
Fromn a discussion in #169 we decided representing tof_binning as the explicit bin size is better than using the current exponent method.
There should however be a note reporting the tof_binning value needs to be a power of 2.
current:
tof[ns] = tof[steps] * tof_binwidth * 2**tof_binning
Proposal:
tof[ns] = tof[steps] * tof_binwidth * tof_binning
The text was updated successfully, but these errors were encountered: