Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenMRS Validation external_id #963

Closed
ibacher opened this issue Sep 8, 2021 · 4 comments
Closed

OpenMRS Validation external_id #963

ibacher opened this issue Sep 8, 2021 · 4 comments
Assignees
@snyaggarwal
Labels
api2 OCL API v2 enhancement New feature or request openmrs

Comments

@ibacher
Copy link

ibacher commented Sep 8, 2021

Is it possible to add a validation to the OpenMRS custom validation scheme to ensure that the external_id field is not longer than 36 characters? We use this field to store the UUID of fields for OpenMRS and fields more than 36 characters long cause issues.
@snyaggarwal
Copy link
Contributor

hey, @ibacher is this validation only for Concept and Mapping or for Source/Collection/Org as well?

@snyaggarwal snyaggarwal added api2 OCL API v2 enhancement New feature or request openmrs labels Sep 14, 2021
@ibacher
Copy link
Author

ibacher commented Sep 14, 2021

Good question! The external_ids we care about are for: concept, mapping, concept name and concept description.

@snyaggarwal
Copy link
Contributor

@ibacher Got it. Will get this done soon.

@snyaggarwal snyaggarwal mentioned this issue Sep 23, 2021
Closed
snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue Sep 28, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#963 | OpenMRS validator external_id for con…
373afff 
…cept/locales/mapping validations
@snyaggarwal
Copy link
Contributor

@paynejd This is available on all environments, can this be closed?

@ibacher ibacher closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snyaggarwal snyaggarwal

Labels
api2 OCL API v2 enhancement New feature or request openmrs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snyaggarwal @ibacher